Fixes #4423 - Getter on mutations size (#4424)

gremi64 · sduskis · commit 64f3b2be23ea · 2019-02-08T10:11:29.000-05:00
* Fixes #4423 Getter over mutations size Allow knowing the size of the list. For exemple, the batch size is limited to 500 mutations * Fixes #4423 - Getter on mutations size Allow knowing the size of the list. For exemple, the batch size is limited to 500 mutations Fixes #4423 * Correction format code
diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
@@ -664,4 +664,9 @@ public List<WriteResult> apply(CommitResponse commitResponse) {
   boolean isEmpty() {
     return mutations.isEmpty();
   }
+
+  /** Get the number of mutations. */
+  public int getMutationsSize() {
+    return mutations.size();
+  }
 }
diff --git a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/WriteBatchTest.java b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/WriteBatchTest.java
@@ -91,6 +91,8 @@ public void updateDocument() throws Exception {
     batch.update(documentReference, updateTime, "foo", "bar");
     batch.update(documentReference, LocalFirestoreHelper.SINGLE_FIELD_MAP, updateTime);
 
+    assertEquals(4, batch.getMutationsSize());
+
     List<WriteResult> writeResults = batch.commit().get();
     List<Write> writes = new ArrayList<>();
 
@@ -126,6 +128,8 @@ public void setDocument() throws Exception {
     writes.add(set(LocalFirestoreHelper.SINGLE_FIELD_PROTO, Arrays.asList("foo")));
     writes.add(set(LocalFirestoreHelper.SINGLE_FIELD_PROTO, Arrays.asList("foo")));
 
+    assertEquals(4, batch.getMutationsSize());
+
     List<WriteResult> writeResults = batch.commit().get();
     for (int i = 0; i < writeResults.size(); ++i) {
       assertEquals(Timestamp.ofTimeSecondsAndNanos(i, i), writeResults.get(i).getUpdateTime());
@@ -144,6 +148,8 @@ public void omitWriteResultForDocumentTransforms() throws Exception {
 
     batch.set(documentReference, map("time", FieldValue.serverTimestamp()));
 
+    assertEquals(1, batch.getMutationsSize());
+
     List<WriteResult> writeResults = batch.commit().get();
     assertEquals(1, writeResults.size());
   }
@@ -159,6 +165,8 @@ public void createDocument() throws Exception {
         .create(documentReference, LocalFirestoreHelper.SINGLE_FIELD_MAP)
         .create(documentReference, LocalFirestoreHelper.SINGLE_FIELD_OBJECT);
 
+    assertEquals(2, batch.getMutationsSize());
+
     List<WriteResult> writeResults = batch.commit().get();
     List<Write> writes = new ArrayList<>();
 
@@ -188,6 +196,8 @@ public void deleteDocument() throws Exception {
     precondition.getUpdateTimeBuilder().setSeconds(1).setNanos(2);
     writes.add(delete(precondition.build()));
 
+    assertEquals(2, batch.getMutationsSize());
+
     List<WriteResult> writeResults = batch.commit().get();
 
     for (int i = 0; i < writeResults.size(); ++i) {

Original file line number	Diff line number	Diff line change
`@@ -664,4 +664,9 @@ public List<WriteResult> apply(CommitResponse commitResponse) {`
`664`	`664`	`boolean isEmpty() {`
`665`	`665`	`return mutations.isEmpty();`
`666`	`666`	`}`
	`667`	`+`
	`668`	`+ /** Get the number of mutations. */`
	`669`	`+ public int getMutationsSize() {`
	`670`	`+ return mutations.size();`
	`671`	`+ }`
`667`	`672`	`}`