Addressing Codacy comments

garrettjonesgoogle · garrettjonesgoogle · commit 64452200821f · 2016-11-18T15:45:22.000-08:00
diff --git a/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/AckDeadlineRenewerTest.java b/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/AckDeadlineRenewerTest.java
@@ -49,7 +49,7 @@ public class AckDeadlineRenewerTest {
   private PubSub pubsub;
   private FakeScheduledExecutorService executorService;
   private AckDeadlineRenewer ackDeadlineRenewer;
-  private FakeClock clock = new FakeClock();
+  private final FakeClock clock = new FakeClock();
 
   @Rule
   public Timeout globalTimeout = Timeout.seconds(60);
diff --git a/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/FakeScheduledExecutorService.java b/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/FakeScheduledExecutorService.java
@@ -19,7 +19,6 @@
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
-import java.util.Vector;
 import java.util.concurrent.Callable;
 import java.util.concurrent.Delayed;
 import java.util.concurrent.ExecutionException;
@@ -34,7 +33,7 @@
  */
 class FakeScheduledExecutorService extends ScheduledThreadPoolExecutor {
   private final FakeClock clock;
-  private final List<FakeScheduledFuture> futures = new Vector<>();
+  private final List<FakeScheduledFuture> futures = new ArrayList<>();
 
   public FakeScheduledExecutorService(int corePoolSize, FakeClock clock) {
     super(corePoolSize);
@@ -106,10 +105,10 @@ private class FakeScheduledFuture implements ScheduledFuture<Object> {
     final TimeUnit unit;
     final long runAtMillis;
 
-    volatile boolean isDone = false;
-    volatile boolean isCancelled = false;
-    volatile Exception exception = null;
-    volatile Object result = null;
+    volatile boolean isDone;
+    volatile boolean isCancelled;
+    volatile Exception exception;
+    volatile Object result;
 
     FakeScheduledFuture(Runnable runnable, long delay, TimeUnit unit, long runAtMillis) {
       this.callable = Executors.callable(runnable);
