Add test for save/restore closed BlobWriteChannelImpl

mziccard · mziccard · commit 638bd92113a3 · 2015-10-19T22:35:16.000+02:00
diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobWriteChannelImpl.java b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobWriteChannelImpl.java
@@ -227,9 +227,11 @@ static Builder builder(StorageOptions options, BlobInfo blobInfo, String uploadI
     @Override
     public BlobWriteChannel restore() {
       BlobWriteChannelImpl channel = new BlobWriteChannelImpl(serviceOptions, blobInfo, uploadId);
+      if (buffer != null) {
+        channel.buffer = buffer.clone();
+        channel.limit = buffer.length;
+      }
       channel.position = position;
-      channel.buffer = buffer.clone();
-      channel.limit = buffer.length;
       channel.isOpen = isOpen;
       channel.chunkSize = chunkSize;
       return channel;
diff --git a/gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobWriteChannelImplTest.java b/gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobWriteChannelImplTest.java
@@ -220,6 +220,32 @@ public void testSaveAndRestore() throws IOException {
     assertEquals(new Long(DEFAULT_CHUNK_SIZE), capturedPosition.getValues().get(1));
   }
 
+  @Test
+  public void testSaveAndRestoreClosed() throws IOException {
+    EasyMock.expect(optionsMock.storageRpc()).andReturn(storageRpcMock).times(2);
+    EasyMock.expect(optionsMock.retryParams()).andReturn(RetryParams.noRetries());
+    EasyMock.replay(optionsMock);
+    EasyMock.expect(storageRpcMock.open(BLOB_INFO.toPb(), EMPTY_RPC_OPTIONS)).andReturn(UPLOAD_ID);
+    Capture<byte[]> capturedBuffer = Capture.newInstance();
+    storageRpcMock.write(EasyMock.eq(UPLOAD_ID), EasyMock.capture(capturedBuffer), EasyMock.eq(0),
+        EasyMock.eq(BLOB_INFO.toPb()), EasyMock.eq(0L), EasyMock.eq(0), EasyMock.eq(true));
+    EasyMock.expectLastCall();
+    EasyMock.replay(storageRpcMock);
+    writer = new BlobWriteChannelImpl(optionsMock, BLOB_INFO, EMPTY_RPC_OPTIONS);
+    writer.close();
+    RestorableState<BlobWriteChannel> writerState = writer.save();
+    RestorableState<BlobWriteChannel> expectedWriterState =
+        BlobWriteChannelImpl.StateImpl.builder(optionsMock, BLOB_INFO, UPLOAD_ID)
+            .buffer(null)
+            .chunkSize(DEFAULT_CHUNK_SIZE)
+            .isOpen(false)
+            .position(0)
+            .build();
+    BlobWriteChannel restoredWriter = writerState.restore();
+    assertArrayEquals(new byte[0], capturedBuffer.getValue());
+    assertEquals(expectedWriterState, restoredWriter.save());
+  }
+
   @Test
   public void testStateEquals() {
     EasyMock.expect(optionsMock.storageRpc()).andReturn(storageRpcMock).times(2);
