---

pongad · web-flow · commit 6231ec86c12b · 2018-02-13T07:52:20.000+11:00
yaml --- r: 9001 b: refs/heads/lesv-patch-1 c: ce6ef37 h: refs/heads/master i: 8999: 6238f58
diff --git a/[refs] b/[refs]
@@ -66,7 +66,7 @@ refs/tags/v0.22.0: 18b298fe4bfe8ec2f20b0e0bf7ffdcce5cc3c5fe
 refs/heads/vam-google-patch-1: d0c8fee3a4074d0bf7360ce8c4f7f7223d0ee7b9
 refs/heads/vam-google-patch-CODEOWNERS: 2ac1616e25229e51d08a984708ef1918f91a35ee
 refs/heads/danoscarmike-patch-1: 7342a9916bce4ed00002c7202e2a16c5d46afaea
-refs/heads/lesv-patch-1: e2f0d20a82e963df7e9a788cd8c26b48b917af61
+refs/heads/lesv-patch-1: ce6ef37c7811e96aaf97777a71e37ed321e10d1a
 refs/heads/ml-update-branch: 079dd6610017f5c51b9d1938c12d6d55b61513cf
 refs/heads/vkedia-patch-2: 7d8241388a9769a5c069334761b06c7012c878e7
 refs/heads/vkedia-patch-3: 4d128043acaa7db9160faf439d2ca6104e8a88cb
diff --git a/branches/lesv-patch-1/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java b/branches/lesv-patch-1/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java
@@ -20,9 +20,9 @@
 import static com.google.common.base.Preconditions.checkState;
 
 import com.google.api.client.util.Data;
+import com.google.api.core.BetaApi;
 import com.google.common.base.MoreObjects;
 import com.google.common.io.BaseEncoding;
-
 import java.io.Serializable;
 import java.util.List;
 import java.util.Map;
@@ -65,7 +65,7 @@ public enum Attribute {
   }
 
   private FieldValue(Attribute attribute, Object value) {
-    this.attribute = attribute;
+    this.attribute = checkNotNull(attribute);
     this.value = value;
   }
 
@@ -251,7 +251,22 @@ public final boolean equals(Object obj) {
     return attribute == other.attribute && Objects.equals(value, other.value);
   }
 
-  static FieldValue of(Attribute attribute, Object value) {
+  /**
+   * Creates an instance of {@code FieldValue}, useful for testing.
+   *
+   * <p>If the {@code attribute} is {@link Attribute#PRIMITIVE}, the {@code value} should be the
+   * string representation of the underlying value, eg {@code "123"} for number {@code 123}.
+   *
+   * <p>If the {@code attribute} is {@link Attribute#REPEATED} or {@link Attribute#RECORD}, the
+   * {@code value} should be {@code List} of {@link FieldValue}s or {@link FieldValueList},
+   * respectively.
+   *
+   * <p>This method is unstable. See <a
+   * href="https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2891">this discussion</a>
+   * for more context.
+   */
+  @BetaApi
+  public static FieldValue of(Attribute attribute, Object value) {
     return new FieldValue(attribute, value);
   }
 
diff --git a/branches/lesv-patch-1/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValueList.java b/branches/lesv-patch-1/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValueList.java
@@ -16,6 +16,7 @@
 
 package com.google.cloud.bigquery;
 
+import com.google.api.core.BetaApi;
 import com.google.common.collect.ImmutableList;
 import java.io.Serializable;
 import java.util.AbstractList;
@@ -84,11 +85,27 @@ public int size() {
     return row.size();
   }
 
-  static FieldValueList of(List<FieldValue> row, FieldList schema) {
+  /**
+   * Creates an instance of {@code FieldValueList}, useful for testing.
+   *
+   * <p>This method is unstable. See <a
+   * href="https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2891">this discussion</a>
+   * for more context.
+   */
+  @BetaApi
+  public static FieldValueList of(List<FieldValue> row, FieldList schema) {
     return new FieldValueList(row, schema);
   }
 
-  static FieldValueList of(List<FieldValue> row, Field... schema) {
+  /**
+   * Creates an instance of {@code FieldValueList}, useful for testing.
+   *
+   * <p>This method is unstable. See <a
+   * href="https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2891">this discussion</a>
+   * for more context.
+   */
+  @BetaApi
+  public static FieldValueList of(List<FieldValue> row, Field... schema) {
     return of(row, schema.length > 0 ? FieldList.of(schema) : null);
   }
 
