Mark entity bindings as unsupported operation and deprecated (#3024)

yihanzhen · pongad · commit 5d86aceace0e · 2018-03-14T10:19:23.000+11:00
Fixes #1485.
diff --git a/google-cloud-datastore/pom.xml b/google-cloud-datastore/pom.xml
@@ -40,6 +40,10 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <groupId>io.grpc</groupId>
+      <artifactId>grpc-core</artifactId>
+    </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>google-cloud-core</artifactId>
diff --git a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java
@@ -27,7 +27,7 @@
 import com.google.common.primitives.Booleans;
 import com.google.common.primitives.Doubles;
 import com.google.common.primitives.Longs;
-
+import io.grpc.Status;
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -282,9 +282,9 @@ public Builder<V> setBinding(String name, Key... value) {
      * @param value a {@link FullEntity} object or a list of {@link FullEntity} objects that binds
      *     to a given name
      */
+    @Deprecated
     public Builder<V> setBinding(String name, FullEntity<?>... value) {
-      namedBindings.put(name, toBinding(EntityValue.MARSHALLER, Arrays.asList(value)));
-      return this;
+      throw new DatastoreException(Status.Code.UNIMPLEMENTED.value(), "Binding entities is not supported.", "UNIMPLEMENTED");
     }
 
     /**
@@ -378,9 +378,9 @@ public Builder<V> addBinding(Key... value) {
      * @param value a {@link FullEntity} object or a list of {@link FullEntity} objects to be set as
      *     a new positional binding
      */
+    @Deprecated
     public Builder<V> addBinding(FullEntity<?>... value) {
-      positionalBindings.add(toBinding(EntityValue.MARSHALLER, Arrays.asList(value)));
-      return this;
+      throw new DatastoreException(Status.Code.UNIMPLEMENTED.value(), "Binding entities is not supported.", "UNIMPLEMENTED");
     }
 
     /**
