Skip to content

Commit 5a6b44a

Browse files
abhinav-qlogicsduskis
authored andcommitted
---
yaml --- r: 29137 b: refs/heads/autosynth-logging c: 9d9404b h: refs/heads/master i: 29135: 6a1a9b3
1 parent 046845b commit 5a6b44a

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ refs/tags/v0.61.0: e4b526656bb1bf5eefd0ee578b7405147821225e
104104
refs/tags/v0.62.0: bbede7385d48ba08f487bdd29ec10668ace96396
105105
refs/heads/0.60.0-alpha: 10939381ffe0b8da32db4fe3087c86e3aa7f3e55
106106
refs/heads/autosynth-dlp: 49572edd157e407b5d979154c583b984e144c79f
107-
refs/heads/autosynth-logging: b2dc157752bd9421852da50d941557bf72cd935e
107+
refs/heads/autosynth-logging: 9d9404b35b673a885e270b39b8c441d35c5bdadd
108108
refs/heads/dupes: 3478c5d81fd242d0e985656645a679420a2060c2
109109
refs/tags/v0.63.0: 94f19b71d40f46b36120e7b9d78a1a3d41bfcbd6
110110
refs/tags/v0.64.0: 456e8fbd129deced3ca025f239a2d8a82bde1d0a

branches/autosynth-logging/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.cloud.firestore.spi.v1.FirestoreRpc;
3030
import com.google.common.base.Preconditions;
3131
import com.google.common.collect.ImmutableMap;
32+
import com.google.common.util.concurrent.MoreExecutors;
3233
import com.google.firestore.v1.BatchGetDocumentsRequest;
3334
import com.google.firestore.v1.BatchGetDocumentsResponse;
3435
import com.google.firestore.v1.DatabaseRootName;
@@ -339,9 +340,11 @@ public void onSuccess(List<WriteResult> writeResults) {
339340
span.end();
340341
resultFuture.set(userResult);
341342
}
342-
});
343+
},
344+
MoreExecutors.directExecutor());
343345
}
344-
});
346+
},
347+
MoreExecutors.directExecutor());
345348
}
346349

347350
private SettableApiFuture<T> invokeUserCallback() {
@@ -396,12 +399,14 @@ public void onFailure(Throwable throwable) {
396399
public void onSuccess(Void ignored) {
397400
resultFuture.setException(throwable);
398401
}
399-
});
402+
},
403+
MoreExecutors.directExecutor());
400404
} else {
401405
resultFuture.setException(throwable);
402406
}
403407
}
404-
});
408+
},
409+
MoreExecutors.directExecutor());
405410
}
406411

407412
/** Returns whether the user has opted into receiving dates as com.google.cloud.Timestamp. */

branches/autosynth-logging/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/spi/v1/GrpcFirestoreRpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public GrpcFirestoreRpc(final FirestoreOptions options) throws IOException {
8585
|| NoCredentials.getInstance().equals(options.getCredentials())) {
8686
ManagedChannel managedChannel =
8787
ManagedChannelBuilder.forTarget(options.getHost())
88-
.usePlaintext(true)
88+
.usePlaintext()
8989
.executor(executor)
9090
.build();
9191
TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel);

0 commit comments

Comments
 (0)