Skip to content

Commit 59fb06d

Browse files
JesseLovelacechingor13
authored andcommitted
---
yaml --- r: 28417 b: refs/heads/master c: fff25ba h: refs/heads/master i: 28415: 8b6c588
1 parent a3e1a51 commit 59fb06d

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 720d90171cd515c21a21f9f8f17d638ff67ec09c
2+
refs/heads/master: fff25ba885353dd4c9499d9084e4463291c72c9a
33
refs/heads/gh-pages: 9b91392095cbb68bba1a32efe7d8caeac44467d9
44
refs/tags/0.0.9: 22f1839238f66c39e67ed4dfdcd273b1ae2e8444
55
refs/tags/v0.0.10: 207ebd2a3472fddee69fe1298eb90429e3306efd

trunk/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ public String strValue() {
255255
* policy identities to {@code Identity} objects.
256256
*/
257257
public static Identity valueOf(String identityStr) {
258-
String[] info = identityStr.split(":");
258+
String[] info = identityStr.split(":", 2);
259259
Type type = Type.valueOf(CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, info[0]));
260260
if (info.length == 1) {
261261
return new Identity(type, null);

trunk/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,16 +141,18 @@ public void testValueOfEmpty() {
141141
Identity.valueOf("");
142142
}
143143

144-
@Test(expected = IllegalArgumentException.class)
145-
public void testValueOfThreePart() {
146-
Identity.valueOf("a:b:c");
147-
}
148-
149144
@Test
150145
public void testUnrecognizedToString() {
151146
assertEquals("a:b", Identity.valueOf("a:b").strValue());
152147
}
153148

149+
@Test
150+
public void testValueOfThreePart() {
151+
Identity identity = Identity.valueOf("a:b:c");
152+
assertEquals("A", identity.getType().name());
153+
assertEquals("b:c", identity.getValue());
154+
}
155+
154156
private void compareIdentities(Identity expected, Identity actual) {
155157
assertEquals(expected, actual);
156158
assertEquals(expected.getType(), actual.getType());

0 commit comments

Comments
 (0)