pr comment

pongad · pongad · commit 59fab43aac1a · 2017-05-27T09:05:42.000+10:00
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -282,85 +282,6 @@ protected void doStop() {
     }
   }
 
-  // private void startStreamingConnections() {
-  //   synchronized (streamingSubscriberConnections) {
-  //     for (int i = 0; i < numChannels; i++) {
-  //       streamingSubscriberConnections.add(
-  //           new StreamingSubscriberConnection(
-  //               cachedSubscriptionNameString,
-  //               receiver,
-  //               ackExpirationPadding,
-  //               maxAckExtensionPeriod,
-  //               streamAckDeadlineSeconds,
-  //               ackLatencyDistribution,
-  //               channels.get(i),
-  //               flowController,
-  //               executor,
-  //               alarmsExecutor,
-  //               clock));
-  //     }
-  //     startConnections(
-  //         streamingSubscriberConnections,
-  //         new Listener() {
-  //           @Override
-  //           public void failed(State from, Throwable failure) {
-  //             // If a connection failed is because of a fatal error, we should fail the
-  //             // whole subscriber.
-  //             stopAllStreamingConnections();
-  //             if (failure instanceof StatusRuntimeException
-  //                 && ((StatusRuntimeException) failure).getStatus().getCode()
-  //                     == Status.Code.UNIMPLEMENTED) {
-  //               logger.info("Unable to open streaming connections, falling back to polling.");
-  //               startPollingConnections();
-  //               return;
-  //             }
-  //             notifyFailed(failure);
-  //           }
-  //         });
-  //   }
-  //
-  //   ackDeadlineUpdater =
-  //       executor.scheduleAtFixedRate(
-  //           new Runnable() {
-  //             @Override
-  //             public void run() {
-  //               // It is guaranteed this will be <= MAX_ACK_DEADLINE_SECONDS, the max of the API.
-  //               long ackLatency =
-  //                   ackLatencyDistribution.getNthPercentile(PERCENTILE_FOR_ACK_DEADLINE_UPDATES);
-  //               if (ackLatency > 0) {
-  //                 long ackExpirationPaddingMillis = ackExpirationPadding.toMillis();
-  //                 int possibleStreamAckDeadlineSeconds =
-  //                     Math.max(
-  //                         MIN_ACK_DEADLINE_SECONDS,
-  //                         Ints.saturatedCast(
-  //                             Math.max(ackLatency,
-  //                                 TimeUnit.MILLISECONDS.toSeconds(ackExpirationPaddingMillis))));
-  //                 if (streamAckDeadlineSeconds != possibleStreamAckDeadlineSeconds) {
-  //                   streamAckDeadlineSeconds = possibleStreamAckDeadlineSeconds;
-  //                   logger.log(
-  //                       Level.FINER,
-  //                       "Updating stream deadline to {0} seconds.",
-  //                       streamAckDeadlineSeconds);
-  //                   for (StreamingSubscriberConnection subscriberConnection :
-  //                       streamingSubscriberConnections) {
-  //                     subscriberConnection.updateStreamAckDeadline(streamAckDeadlineSeconds);
-  //                   }
-  //                 }
-  //               }
-  //             }
-  //           },
-  //           ACK_DEADLINE_UPDATE_PERIOD.toMillis(),
-  //           ACK_DEADLINE_UPDATE_PERIOD.toMillis(),
-  //           TimeUnit.MILLISECONDS);
-  // }
-  //
-  // private void stopAllStreamingConnections() {
-  //   stopConnections(streamingSubscriberConnections);
-  //   if (ackDeadlineUpdater != null) {
-  //     ackDeadlineUpdater.cancel(true);
-  //   }
-  // }
-
   private void startPollingConnections() throws IOException {
     synchronized (pollingSubscriberConnections) {
       Credentials credentials = credentialsProvider.getCredentials();
