Addressing PR feedback

garrettjonesgoogle · garrettjonesgoogle · commit 58d180bd0f70 · 2016-11-22T14:06:20.000-08:00
diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/ConfigServiceV2Client.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/ConfigServiceV2Client.java
@@ -223,7 +223,6 @@ public final ConfigServiceV2Settings getSettings() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final ListSinksPagedResponse listSinks(String parent) {
-    PARENT_PATH_TEMPLATE.validate(parent, "listSinks");
     ListSinksRequest request = ListSinksRequest.newBuilder().setParent(parent).build();
     return listSinks(request);
   }
@@ -327,7 +326,7 @@ public final UnaryCallable<ListSinksRequest, ListSinksResponse> listSinksCallabl
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final LogSink getSink(String sinkName) {
-    SINK_PATH_TEMPLATE.validate(sinkName, "getSink");
+
     GetSinkRequest request = GetSinkRequest.newBuilder().setSinkName(sinkName).build();
     return getSink(request);
   }
@@ -398,7 +397,7 @@ public final UnaryCallable<GetSinkRequest, LogSink> getSinkCallable() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final LogSink createSink(String parent, LogSink sink) {
-    PARENT_PATH_TEMPLATE.validate(parent, "createSink");
+
     CreateSinkRequest request =
         CreateSinkRequest.newBuilder().setParent(parent).setSink(sink).build();
     return createSink(request);
@@ -477,7 +476,7 @@ public final UnaryCallable<CreateSinkRequest, LogSink> createSinkCallable() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final LogSink updateSink(String sinkName, LogSink sink) {
-    SINK_PATH_TEMPLATE.validate(sinkName, "updateSink");
+
     UpdateSinkRequest request =
         UpdateSinkRequest.newBuilder().setSinkName(sinkName).setSink(sink).build();
     return updateSink(request);
@@ -553,7 +552,7 @@ public final UnaryCallable<UpdateSinkRequest, LogSink> updateSinkCallable() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final void deleteSink(String sinkName) {
-    SINK_PATH_TEMPLATE.validate(sinkName, "deleteSink");
+
     DeleteSinkRequest request = DeleteSinkRequest.newBuilder().setSinkName(sinkName).build();
     deleteSink(request);
   }
diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/LoggingServiceV2Client.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/LoggingServiceV2Client.java
@@ -237,7 +237,7 @@ public final LoggingServiceV2Settings getSettings() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final void deleteLog(String logName) {
-    LOG_PATH_TEMPLATE.validate(logName, "deleteLog");
+
     DeleteLogRequest request = DeleteLogRequest.newBuilder().setLogName(logName).build();
     deleteLog(request);
   }
@@ -331,9 +331,7 @@ public final WriteLogEntriesResponse writeLogEntries(
       MonitoredResource resource,
       Map<String, String> labels,
       List<LogEntry> entries) {
-    if (!logName.isEmpty()) {
-      LOG_PATH_TEMPLATE.validate(logName, "writeLogEntries");
-    }
+
     WriteLogEntriesRequest request =
         WriteLogEntriesRequest.newBuilder()
             .setLogName(logName)
diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/MetricsServiceV2Client.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/MetricsServiceV2Client.java
@@ -225,7 +225,6 @@ public final MetricsServiceV2Settings getSettings() {
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final ListLogMetricsPagedResponse listLogMetrics(String parent) {
-    PARENT_PATH_TEMPLATE.validate(parent, "listLogMetrics");
     ListLogMetricsRequest request = ListLogMetricsRequest.newBuilder().setParent(parent).build();
     return listLogMetrics(request);
   }
@@ -402,7 +401,7 @@ public final UnaryCallable<GetLogMetricRequest, LogMetric> getLogMetricCallable(
    * @throws com.google.api.gax.grpc.ApiException if the remote call fails
    */
   public final LogMetric createLogMetric(String parent, LogMetric metric) {
-    PARENT_PATH_TEMPLATE.validate(parent, "createLogMetric");
+
     CreateLogMetricRequest request =
         CreateLogMetricRequest.newBuilder().setParent(parent).setMetric(metric).build();
     return createLogMetric(request);
diff --git a/google-cloud-speech/src/main/java/com/google/cloud/speech/spi/v1beta1/SpeechClient.java b/google-cloud-speech/src/main/java/com/google/cloud/speech/spi/v1beta1/SpeechClient.java
@@ -183,6 +183,10 @@ public final SpeechSettings getSettings() {
     return settings;
   }
 
+  /**
+   * Returns the OperationsClient that can be used to query the status of a long-running operation
+   * returned by another API method call.
+   */
   public final OperationsClient getOperationsClient() {
     return operationsClient;
   }

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,10 @@ public final SpeechSettings getSettings() {`
`183`	`183`	`return settings;`
`184`	`184`	`}`
`185`	`185`
	`186`	`+ /**`
	`187`	`+ * Returns the OperationsClient that can be used to query the status of a long-running operation`
	`188`	`+ * returned by another API method call.`
	`189`	`+ */`
`186`	`190`	`public final OperationsClient getOperationsClient() {`
`187`	`191`	`return operationsClient;`
`188`	`192`	`}`