---

JesseLovelace · chingor13 · commit 586f149ef6e8 · 2019-05-22T13:51:31.000-07:00
yaml --- r: 34045 b: refs/heads/autosynth-spanner c: fff25ba h: refs/heads/master i: 34043: 1cc1e6e
diff --git a/[refs] b/[refs]
@@ -137,7 +137,7 @@ refs/heads/autosynth-language: 6130869312f99a1e7d3aa0485759172a23333cc5
 refs/heads/autosynth-os-login: 49028d40ac477fca5f948cc5a3ce7422729fdb67
 refs/heads/autosynth-redis: 2b698ebe7faaa0b93246576a88941682e0888e57
 refs/heads/autosynth-scheduler: a3de6480746d1cd586ca8b9d75c55a636f371539
-refs/heads/autosynth-spanner: 720d90171cd515c21a21f9f8f17d638ff67ec09c
+refs/heads/autosynth-spanner: fff25ba885353dd4c9499d9084e4463291c72c9a
 refs/heads/autosynth-speech: 64692f6db11364f663921be02c08072b966b6e7b
 refs/heads/autosynth-tasks: eb03eeab747e925175890db923945384d89b273a
 refs/heads/autosynth-texttospeech: 2c442fe0b7f089fbab266edfe4dd83c532e82dd0
diff --git a/branches/autosynth-spanner/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java b/branches/autosynth-spanner/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java
@@ -255,7 +255,7 @@ public String strValue() {
    * policy identities to {@code Identity} objects.
    */
   public static Identity valueOf(String identityStr) {
-    String[] info = identityStr.split(":");
+    String[] info = identityStr.split(":", 2);
     Type type = Type.valueOf(CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, info[0]));
     if (info.length == 1) {
       return new Identity(type, null);
diff --git a/branches/autosynth-spanner/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java b/branches/autosynth-spanner/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java
@@ -141,16 +141,18 @@ public void testValueOfEmpty() {
     Identity.valueOf("");
   }
 
-  @Test(expected = IllegalArgumentException.class)
-  public void testValueOfThreePart() {
-    Identity.valueOf("a:b:c");
-  }
-
   @Test
   public void testUnrecognizedToString() {
     assertEquals("a:b", Identity.valueOf("a:b").strValue());
   }
 
+  @Test
+  public void testValueOfThreePart() {
+    Identity identity = Identity.valueOf("a:b:c");
+    assertEquals("A", identity.getType().name());
+    assertEquals("b:c", identity.getValue());
+  }
+
   private void compareIdentities(Identity expected, Identity actual) {
     assertEquals(expected, actual);
     assertEquals(expected.getType(), actual.getType());
