Skip to content

Commit 5764d49

Browse files
committed
rename MessagesProcessor to MessageDispatcher
Fixes #1546
1 parent d70aaf7 commit 5764d49

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessagesProcessor.java renamed to google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
* Dispatches messages to a message receiver while handling the messages acking and lease
5252
* extensions.
5353
*/
54-
class MessagesProcessor {
55-
private static final Logger logger = LoggerFactory.getLogger(MessagesProcessor.class);
54+
class MessageDispatcher {
55+
private static final Logger logger = LoggerFactory.getLogger(MessageDispatcher.class);
5656

5757
private static final int INITIAL_ACK_DEADLINE_EXTENSION_SECONDS = 2;
5858
@VisibleForTesting static final Duration PENDING_ACKS_SEND_DELAY = Duration.millis(100);
@@ -204,7 +204,7 @@ void sendAckOperations(
204204
List<String> acksToSend, List<PendingModifyAckDeadline> ackDeadlineExtensions);
205205
}
206206

207-
MessagesProcessor(
207+
MessageDispatcher(
208208
MessageReceiver receiver,
209209
AcksProcessor acksProcessor,
210210
Duration ackExpirationPadding,

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import com.google.api.stats.Distribution;
2323
import com.google.auth.Credentials;
2424
import com.google.cloud.Clock;
25-
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.AcksProcessor;
26-
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.PendingModifyAckDeadline;
25+
import com.google.cloud.pubsub.spi.v1.MessageDispatcher.AcksProcessor;
26+
import com.google.cloud.pubsub.spi.v1.MessageDispatcher.PendingModifyAckDeadline;
2727
import com.google.common.collect.Lists;
2828
import com.google.common.util.concurrent.AbstractService;
2929
import com.google.common.util.concurrent.FutureCallback;
@@ -63,7 +63,7 @@ final class PollingSubscriberConnection extends AbstractService implements AcksP
6363
private final String subscription;
6464
private final ScheduledExecutorService executor;
6565
private final SubscriberFutureStub stub;
66-
private final MessagesProcessor messagesProcessor;
66+
private final MessageDispatcher messagesProcessor;
6767

6868
public PollingSubscriberConnection(
6969
String subscription,
@@ -81,7 +81,7 @@ public PollingSubscriberConnection(
8181
SubscriberGrpc.newFutureStub(channel)
8282
.withCallCredentials(MoreCallCredentials.from(credentials));
8383
messagesProcessor =
84-
new MessagesProcessor(
84+
new MessageDispatcher(
8585
receiver,
8686
this,
8787
ackExpirationPadding,

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import com.google.api.stats.Distribution;
2323
import com.google.auth.Credentials;
2424
import com.google.cloud.Clock;
25-
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.AcksProcessor;
26-
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.PendingModifyAckDeadline;
25+
import com.google.cloud.pubsub.spi.v1.MessageDispatcher.AcksProcessor;
26+
import com.google.cloud.pubsub.spi.v1.MessageDispatcher.PendingModifyAckDeadline;
2727
import com.google.common.collect.Lists;
2828
import com.google.common.util.concurrent.AbstractService;
2929
import com.google.common.util.concurrent.FutureCallback;
@@ -62,7 +62,7 @@ final class StreamingSubscriberConnection extends AbstractService implements Ack
6262

6363
private final String subscription;
6464
private final ScheduledExecutorService executor;
65-
private final MessagesProcessor messagesProcessor;
65+
private final MessageDispatcher messagesProcessor;
6666
private ClientCallStreamObserver<StreamingPullRequest> requestObserver;
6767

6868
public StreamingSubscriberConnection(
@@ -81,7 +81,7 @@ public StreamingSubscriberConnection(
8181
this.credentials = credentials;
8282
this.channel = channel;
8383
this.messagesProcessor =
84-
new MessagesProcessor(
84+
new MessageDispatcher(
8585
receiver,
8686
this,
8787
ackExpirationPadding,

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/SubscriberImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.cloud.pubsub.spi.v1;
1818

19-
import static com.google.cloud.pubsub.spi.v1.MessagesProcessor.PENDING_ACKS_SEND_DELAY;
19+
import static com.google.cloud.pubsub.spi.v1.MessageDispatcher.PENDING_ACKS_SEND_DELAY;
2020
import static org.junit.Assert.assertEquals;
2121

2222
import com.google.cloud.pubsub.spi.v1.FakeSubscriberServiceImpl.ModifyAckDeadline;

0 commit comments

Comments
 (0)