pubsub: make logs quieter (#2492)

pongad · web-flow · commit 540734e6e9bc · 2017-10-10T06:19:00.000+11:00
Retryable stream closure happens quite often.
This commit lowers the log level to FINE to not spam the console.
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
@@ -229,11 +229,12 @@ public void onFailure(Throwable cause) {
               logger.log(Level.FINE, "pull failure after service no longer running", cause);
               return;
             }
-            logger.log(Level.WARNING, "Terminated streaming with exception", cause);
             if (!StatusUtil.isRetryable(cause)) {
+              logger.log(Level.SEVERE, "terminated streaming with exception", cause);
               notifyFailed(cause);
               return;
             }
+            logger.log(Level.FINE, "stream closed with retryable exception; will reconnect", cause);
             long backoffMillis = channelReconnectBackoffMillis.get();
             long newBackoffMillis =
                 Math.min(backoffMillis * 2, MAX_CHANNEL_RECONNECT_BACKOFF.toMillis());

Original file line number	Diff line number	Diff line change
`@@ -229,11 +229,12 @@ public void onFailure(Throwable cause) {`
`229`	`229`	`logger.log(Level.FINE, "pull failure after service no longer running", cause);`
`230`	`230`	`return;`
`231`	`231`	`}`
`232`		`- logger.log(Level.WARNING, "Terminated streaming with exception", cause);`
`233`	`232`	`if (!StatusUtil.isRetryable(cause)) {`
	`233`	`+ logger.log(Level.SEVERE, "terminated streaming with exception", cause);`
`234`	`234`	`notifyFailed(cause);`
`235`	`235`	`return;`
`236`	`236`	`}`
	`237`	`+ logger.log(Level.FINE, "stream closed with retryable exception; will reconnect", cause);`
`237`	`238`	`long backoffMillis = channelReconnectBackoffMillis.get();`
`238`	`239`	`long newBackoffMillis =`
`239`	`240`	`Math.min(backoffMillis * 2, MAX_CHANNEL_RECONNECT_BACKOFF.toMillis());`