Pubsub snippets minor updates (#2046)

jabubake · web-flow · commit 4cf6e2533895 · 2017-05-09T21:33:08.000-07:00
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndConsumeMessages.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndConsumeMessages.java
@@ -33,8 +33,8 @@
 public class CreateSubscriptionAndConsumeMessages {
 
   public static void main(String... args) throws Exception {
-    TopicName topic = TopicName.create("test-project", "test-topic");
-    SubscriptionName subscription = SubscriptionName.create("test-project", "test-subscription");
+    TopicName topic = TopicName.create("my-project-id", "my-topic-id");
+    SubscriptionName subscription = SubscriptionName.create("my-project-id", "my-topic-id");
 
     try (SubscriptionAdminClient subscriptionAdminClient = SubscriptionAdminClient.create()) {
       subscriptionAdminClient.createSubscription(subscription, topic, PushConfig.getDefaultInstance(), 0);
@@ -44,7 +44,7 @@ public static void main(String... args) throws Exception {
         new MessageReceiver() {
           @Override
           public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
-            System.out.println("got message: " + message.getData().toStringUtf8());
+            System.out.println("Received message: " + message.getData().toStringUtf8());
             consumer.ack();
           }
         };
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateTopicAndPublishMessages.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateTopicAndPublishMessages.java
@@ -34,15 +34,15 @@
 public class CreateTopicAndPublishMessages {
 
   public static void createTopic() throws Exception {
-    TopicName topic = TopicName.create("test-project", "test-topic");
+    TopicName topic = TopicName.create("my-project-id", "my-topic-id");
     try (TopicAdminClient topicAdminClient = TopicAdminClient.create()) {
       topicAdminClient.createTopic(topic);
     }
   }
 
   public static void publishMessages() throws Exception {
     // [START publish]
-    TopicName topicName = TopicName.create("test-project", "test-topic");
+    TopicName topicName = TopicName.create("my-project-id", "my-topic-id");
     Publisher publisher = null;
     List<ApiFuture<String>> messageIdFutures = new ArrayList<>();
 
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java
@@ -86,8 +86,9 @@ private void createSubscriber() throws Exception {
     MessageReceiver receiver = new MessageReceiver() {
           @Override
           public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
-            // handle incoming message, then ack or nack the received message
-            // ...
+            // handle incoming message, then ack/nack the received message
+            System.out.println("Id : " + message.getMessageId());
+            System.out.println("Data : " + message.getData().toStringUtf8());
             consumer.ack();
           }
         };
@@ -107,10 +108,8 @@ public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
     // [END pullSubscriber]
   }
 
-  private Subscriber createSubscriberWithErrorListener() throws Exception {
+  private Subscriber createSubscriberWithErrorListener(Subscriber subscriber) throws Exception {
     // [START subscriberWithErrorListener]
-    Subscriber subscriber = Subscriber.defaultBuilder(subscriptionName, receiver).build();
-
     subscriber.addListener(new Subscriber.Listener() {
       public void failed(Subscriber.State from, Throwable failure) {
         // Handle error.
