Skip to content

Commit 4a2a73e

Browse files
mziccardmziccard
committed
---
yaml --- r: 1671 b: refs/heads/master c: 0bea6e8 h: refs/heads/master i: 1669: 1398b61 1667: 7e1f14f 1663: 95b4bf0
1 parent 622109f commit 4a2a73e

17 files changed

Lines changed: 35 additions & 34 deletions

File tree

‎[refs]‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 7864a93b8818f89407227732f6cc1c67791f56c7
2+
refs/heads/master: 0bea6e84bae8496cf27df72c637e1ca994f75142
33
refs/heads/travis: e21ee7b88a5edc3f3d8c71f90c3fc32abf7e8dd6
44
refs/heads/gh-pages: d1b373c30c176edc08692348167bec3a244bb823
55
refs/heads/bigquery: 762fa5830e6c398c0396177e3e7fd243bd62cfc3

‎trunk/README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Java idiomatic client for [Google Cloud Platform][cloud-platform] services.
66
[![Build Status](https://travis-ci.org/GoogleCloudPlatform/gcloud-java.svg?branch=master)](https://travis-ci.org/GoogleCloudPlatform/gcloud-java)
77
[![Coverage Status](https://coveralls.io/repos/GoogleCloudPlatform/gcloud-java/badge.svg?branch=master)](https://coveralls.io/r/GoogleCloudPlatform/gcloud-java?branch=master)
88
[![Maven](https://img.shields.io/maven-central/v/com.google.gcloud/gcloud-java.svg)]( https://img.shields.io/maven-central/v/com.google.gcloud/gcloud-java.svg)
9+
[![Codacy Badge](https://api.codacy.com/project/badge/grade/9da006ad7c3a4fe1abd142e77c003917)](https://www.codacy.com/app/mziccard/gcloud-java)
910

1011
- [Homepage] (https://googlecloudplatform.github.io/gcloud-java/)
1112
- [API Documentation] (http://googlecloudplatform.github.io/gcloud-java/apidocs)

‎trunk/gcloud-java-bigquery/README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Java idiomatic client for [Google Cloud BigQuery] (https://cloud.google.com/bigq
66
[![Build Status](https://travis-ci.org/GoogleCloudPlatform/gcloud-java.svg?branch=master)](https://travis-ci.org/GoogleCloudPlatform/gcloud-java)
77
[![Coverage Status](https://coveralls.io/repos/GoogleCloudPlatform/gcloud-java/badge.svg?branch=master)](https://coveralls.io/r/GoogleCloudPlatform/gcloud-java?branch=master)
88
[![Maven](https://img.shields.io/maven-central/v/com.google.gcloud/gcloud-java-bigquery.svg)]( https://img.shields.io/maven-central/v/com.google.gcloud/gcloud-java-bigquery.svg)
9+
[![Codacy Badge](https://api.codacy.com/project/badge/grade/9da006ad7c3a4fe1abd142e77c003917)](https://www.codacy.com/app/mziccard/gcloud-java)
910

1011
- [Homepage] (https://googlecloudplatform.github.io/gcloud-java/)
1112
- [API Documentation] (http://googlecloudplatform.github.io/gcloud-java/apidocs/index.html?com/google/gcloud/bigquery/package-summary.html)

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/DatasetInfo.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,8 +396,7 @@ public int hashCode() {
396396

397397
@Override
398398
public boolean equals(Object obj) {
399-
return obj != null
400-
&& obj.getClass().equals(DatasetInfo.class)
399+
return obj.getClass().equals(DatasetInfo.class)
401400
&& Objects.equals(toPb(), ((DatasetInfo) obj).toPb());
402401
}
403402

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/ExternalTableDefinition.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import java.util.Objects;
2929

3030
/**
31-
* Google BigQuery external table definition. BigQuery's external tables are tables whose data
32-
* reside outside of BigQuery but can be queried as normal BigQuery tables. External tables are
31+
* Google BigQuery external table type. BigQuery's external tables are tables whose data reside
32+
* outside of BigQuery but can be queried as normal BigQuery tables. External tables are
3333
* experimental and might be subject to change or removed.
3434
*
3535
* @see <a href="https://cloud.google.com/bigquery/federated-data-sources">Federated Data Sources

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/JobInfo.java‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,7 @@ public int hashCode() {
319319

320320
@Override
321321
public boolean equals(Object obj) {
322-
return obj != null
323-
&& obj.getClass().equals(JobInfo.class)
324-
&& Objects.equals(toPb(), ((JobInfo) obj).toPb());
322+
return obj.getClass().equals(JobInfo.class) && Objects.equals(toPb(), ((JobInfo) obj).toPb());
325323
}
326324

327325
JobInfo setProjectId(String projectId) {

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/StandardTableDefinition.java‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,10 @@
2626
import java.util.Objects;
2727

2828
/**
29-
* A Google BigQuery default table definition. This definition is used for standard, two-dimensional
30-
* tables with individual records organized in rows, and a data type assigned to each column (also
31-
* called a field). Individual fields within a record may contain nested and repeated children
32-
* fields. Every table is described by a schema that describes field names, types, and other
33-
* information.
29+
* A Google BigQuery default table type. This type is used for standard, two-dimensional tables with
30+
* individual records organized in rows, and a data type assigned to each column (also called a
31+
* field). Individual fields within a record may contain nested and repeated children fields. Every
32+
* table is described by a schema that describes field names, types, and other information.
3433
*
3534
* @see <a href="https://cloud.google.com/bigquery/docs/tables">Managing Tables</a>
3635
*/
@@ -219,14 +218,14 @@ public StreamingBuffer streamingBuffer() {
219218
}
220219

221220
/**
222-
* Returns a builder for a BigQuery standard table definition.
221+
* Returns a builder for a BigQuery default table type.
223222
*/
224223
public static Builder builder() {
225224
return new Builder();
226225
}
227226

228227
/**
229-
* Creates a BigQuery standard table definition given its schema.
228+
* Creates a BigQuery default table type given its schema.
230229
*
231230
* @param schema the schema of the table
232231
*/

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Table.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,7 @@ public InsertAllResponse insert(Iterable<InsertAllRequest.RowToInsert> rows,
213213
* @param options table data list options
214214
* @throws BigQueryException upon failure
215215
*/
216-
public Page<List<FieldValue>> list(BigQuery.TableDataListOption... options)
217-
throws BigQueryException {
216+
public Page<List<FieldValue>> list(BigQuery.TableDataListOption... options) throws BigQueryException {
218217
return bigquery.listTableData(tableId(), options);
219218
}
220219

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableDefinition.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import java.util.Objects;
2626

2727
/**
28-
* Base class for a Google BigQuery table definition.
28+
* Base class for a Google BigQuery table type.
2929
*/
3030
public abstract class TableDefinition implements Serializable {
3131

@@ -63,10 +63,10 @@ public enum Type {
6363
}
6464

6565
/**
66-
* Base builder for table definitions.
66+
* Base builder for table types.
6767
*
68-
* @param <T> the table definition class
69-
* @param <B> the table definition builder
68+
* @param <T> the table type class
69+
* @param <B> the table type builder
7070
*/
7171
public abstract static class Builder<T extends TableDefinition, B extends Builder<T, B>> {
7272

@@ -152,8 +152,8 @@ final int baseHashCode() {
152152
return Objects.hash(type);
153153
}
154154

155-
final boolean baseEquals(TableDefinition tableDefinition) {
156-
return Objects.equals(toPb(), tableDefinition.toPb());
155+
final boolean baseEquals(TableDefinition jobConfiguration) {
156+
return Objects.equals(toPb(), jobConfiguration.toPb());
157157
}
158158

159159
Table toPb() {

‎trunk/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableInfo.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,7 @@ public int hashCode() {
339339

340340
@Override
341341
public boolean equals(Object obj) {
342-
return obj != null
343-
&& obj.getClass().equals(TableInfo.class)
342+
return obj.getClass().equals(TableInfo.class)
344343
&& Objects.equals(toPb(), ((TableInfo) obj).toPb());
345344
}
346345

0 commit comments

Comments
 (0)