---

aozarov · aozarov · commit 49ce0bcef647 · 2015-10-08T11:08:19.000-07:00
yaml --- r: 6219 b: refs/heads/tswast-patch-1 c: 234f964 h: refs/heads/master i: 6217: decc7b6 6215: 3650cd3
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: 385dd4efdd1a0d5a3be81bf4a5d89d87ca167449
+refs/heads/tswast-patch-1: 234f96414d6c404f09b752cf3cb2f714439ddb80
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/spi/DefaultDatastoreRpc.java b/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/spi/DefaultDatastoreRpc.java
@@ -32,6 +32,7 @@
 import com.google.api.services.datastore.client.DatastoreException;
 import com.google.api.services.datastore.client.DatastoreFactory;
 import com.google.api.services.datastore.client.DatastoreOptions.Builder;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableMap;
 import com.google.gcloud.datastore.DatastoreOptions;
 import com.google.gcloud.spi.DatastoreRpc.DatastoreRpcException.Reason;
@@ -40,6 +41,10 @@
 import org.json.JSONObject;
 import org.json.JSONTokener;
 
+import java.net.InetAddress;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.UnknownHostException;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -62,14 +67,45 @@ public class DefaultDatastoreRpc implements DatastoreRpc {
   }
 
   public DefaultDatastoreRpc(DatastoreOptions options) {
+    String normalizedHost = normalizeHost(options.host());
     client = DatastoreFactory.get().create(
         new Builder()
             .dataset(options.projectId())
-            .host(options.host())
+            .host(normalizedHost)
             .initializer(options.httpRequestInitializer())
             .build());
   }
 
+  private static String normalizeHost(String host) {
+    host = host.toLowerCase();
+    if (includesScheme(host)) {
+      Preconditions.checkArgument(!(host.startsWith("https://") && isLocalHost(host)), 
+          "\"https\" is not supported for localhost.  Use \"http\" instead.");
+      return host;
+    }
+    return "http://" + host;
+  }
+
+  private static boolean isLocalHost(String host) {
+    if (host != null) {
+      try {
+        String normalizedHost = host;
+        if (!includesScheme(normalizedHost)) {
+          normalizedHost = "http://" + normalizedHost;
+        }
+        InetAddress hostAddr = InetAddress.getByName(new URL(normalizedHost).getHost());
+        return hostAddr.isAnyLocalAddress() || hostAddr.isLoopbackAddress();
+      } catch (UnknownHostException | MalformedURLException e) {
+        // ignore
+      }
+    }
+    return false;
+  }
+
+  private static boolean includesScheme(String url) {
+    return url.startsWith("http://") || url.startsWith("https://");
+  }
+
   private static DatastoreRpcException translate(DatastoreException exception) {
     String message = exception.getMessage();
     String reasonStr = "";
