incorporate feedbacks

neozwu · neozwu · commit 47e086dd000f · 2017-04-17T16:11:14.000-07:00
diff --git a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionExceptionHandler.java
@@ -22,13 +22,13 @@
 public class TransactionExceptionHandler {
   public static final Interceptor TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR =
       new Interceptor() {
-        private final int ABORTED_CODE = 10;
+        private static final int ABORTED_CODE = 10;
 
         @Override
         public RetryResult beforeEval(Exception exception) {
           if (exception instanceof DatastoreException) {
             DatastoreException e = getInnerException((DatastoreException) exception);
-            if (e.getCode() == ABORTED_CODE || e.getReason() == "ABORTED") {
+            if (e.getCode() == ABORTED_CODE || e.getReason().equals("ABORTED")) {
               return Interceptor.RetryResult.RETRY;
             }
           }
@@ -55,4 +55,7 @@ public static ExceptionHandler build() {
             DatastoreImpl.EXCEPTION_HANDLER_INTERCEPTOR, TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR)
         .build();
   }
+
+  /** Intentionally private empty constructor to disable instantiation of this class. */
+  private TransactionExceptionHandler() {}
 }

Original file line number	Diff line number	Diff line change
`@@ -22,13 +22,13 @@`
`22`	`22`	`public class TransactionExceptionHandler {`
`23`	`23`	`public static final Interceptor TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR =`
`24`	`24`	`new Interceptor() {`
`25`		`- private final int ABORTED_CODE = 10;`
	`25`	`+ private static final int ABORTED_CODE = 10;`
`26`	`26`
`27`	`27`	`@Override`
`28`	`28`	`public RetryResult beforeEval(Exception exception) {`
`29`	`29`	`if (exception instanceof DatastoreException) {`
`30`	`30`	`DatastoreException e = getInnerException((DatastoreException) exception);`
`31`		`- if (e.getCode() == ABORTED_CODE \|\| e.getReason() == "ABORTED") {`
	`31`	`+ if (e.getCode() == ABORTED_CODE \|\| e.getReason().equals("ABORTED")) {`
`32`	`32`	`return Interceptor.RetryResult.RETRY;`
`33`	`33`	`}`
`34`	`34`	`}`
`@@ -55,4 +55,7 @@ public static ExceptionHandler build() {`
`55`	`55`	`DatastoreImpl.EXCEPTION_HANDLER_INTERCEPTOR, TRANSACTION_EXCEPTION_HANDLER_INTERCEPTOR)`
`56`	`56`	`.build();`
`57`	`57`	`}`
	`58`	`+`
	`59`	`+ /** Intentionally private empty constructor to disable instantiation of this class. */`
	`60`	`+ private TransactionExceptionHandler() {}`
`58`	`61`	`}`