---

mziccard · mziccard · commit 47b578b58022 · 2015-10-26T09:46:02.000+01:00
yaml --- r: 6367 b: refs/heads/tswast-patch-1 c: fe98cb4 h: refs/heads/master i: 6365: a50b7c8 6363: dceed7d 6359: a976de0 6351: 4b2352a 6335: a353f43
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: 33e932e533bc9e8c1ecbe2587d662cc728447162
+refs/heads/tswast-patch-1: fe98cb412dfbcf9c87dbf120cf5dc25f11781ae1
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java b/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java
@@ -293,7 +293,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
       Map<Option, ?> targetOptions) throws StorageException {
     ComposeRequest request = new ComposeRequest();
     if (target.getContentType() == null) {
-      // todo: remove once this is no longer requirement (b/20681287).
       target.setContentType("application/octet-stream");
     }
     request.setDestination(target);
@@ -311,7 +310,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
     }
     request.setSourceObjects(sourceObjects);
     try {
-      // todo: missing setProjection (b/20659000)
       return storage.objects()
           .compose(target.getBucket(), target.getName(), request)
           .setIfMetagenerationMatch(IF_METAGENERATION_MATCH.getLong(targetOptions))
@@ -435,7 +433,6 @@ public byte[] read(StorageObject from, Map<Option, ?> options, long position, in
           .setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options))
           .setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options));
       MediaHttpDownloader downloader = req.getMediaHttpDownloader();
-      // todo: Fix int casting (https://github.com/google/google-api-java-client/issues/937)
       downloader.setContentRange(position, (int) position + bytes);
       downloader.setDirectDownloadEnabled(true);
       ByteArrayOutputStream output = new ByteArrayOutputStream();
diff --git a/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java b/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java
@@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) {
   StorageImpl(StorageOptions options) {
     super(options);
     storageRpc = options.storageRpc();
-    // todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite
-    // todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) {`
`102`	`102`	`StorageImpl(StorageOptions options) {`
`103`	`103`	`super(options);`
`104`	`104`	`storageRpc = options.storageRpc();`
`105`		`- // todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite`
`106`		`- // todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch`
`107`	`105`	`}`
`108`	`106`
`109`	`107`	`@Override`