Adding test for return value of runTransaction() (#2801)

schmidt-sebastian · web-flow · commit 42ba22278d9f · 2018-01-23T16:49:45.000-08:00
diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/TransactionTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/TransactionTest.java
@@ -53,6 +53,7 @@
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicInteger;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -273,17 +274,19 @@ public void limitsRetriesWithSuccess() throws Exception {
         .when(firestoreMock)
         .sendRequest(requestCapture.capture(), Matchers.<UnaryCallable<Message, Message>>any());
 
+    final AtomicInteger retryCount = new AtomicInteger(1);
+
     ApiFuture<String> transaction =
         firestoreMock.runTransaction(
             new Transaction.Function<String>() {
               @Override
               public String updateCallback(Transaction transaction) {
-                return "foo";
+                return "foo" + retryCount.getAndIncrement();
               }
             },
             TransactionOptions.create(options.getExecutor(), 6));
 
-    assertEquals("foo", transaction.get());
+    assertEquals("foo6", transaction.get());
 
     List<Message> requests = requestCapture.getAllValues();
     assertEquals(12, requests.size());
