Skip to content

Commit 3fafe20

Browse files
authored
---
yaml --- r: 13733 b: refs/heads/autosynth-logging c: ea68410 h: refs/heads/master i: 13731: f979b53
1 parent 402d5c8 commit 3fafe20

3 files changed

Lines changed: 17 additions & 2 deletions

File tree

  • branches/autosynth-logging/google-cloud-clients/google-cloud-bigquery/src

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ refs/tags/v0.61.0: e4b526656bb1bf5eefd0ee578b7405147821225e
105105
refs/tags/v0.62.0: bbede7385d48ba08f487bdd29ec10668ace96396
106106
refs/heads/0.60.0-alpha: 10939381ffe0b8da32db4fe3087c86e3aa7f3e55
107107
refs/heads/autosynth-dlp: 90e4efe3be392e89dc36bce22afab981a905b1bc
108-
refs/heads/autosynth-logging: 2aa9d803ed532d91a5f430368f1ec4fd21f3dd24
108+
refs/heads/autosynth-logging: ea68410f175b64ab06ff8bd1371935d12e3ce3e9
109109
refs/heads/dupes: 3478c5d81fd242d0e985656645a679420a2060c2
110110
refs/tags/v0.63.0: 94f19b71d40f46b36120e7b9d78a1a3d41bfcbd6
111111
refs/tags/v0.64.0: 456e8fbd129deced3ca025f239a2d8a82bde1d0a

branches/autosynth-logging/google-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Schema.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,13 @@
1818

1919
import static com.google.common.base.Preconditions.checkNotNull;
2020

21+
import com.google.api.services.bigquery.model.TableFieldSchema;
2122
import com.google.api.services.bigquery.model.TableSchema;
2223
import com.google.common.base.Function;
2324
import com.google.common.base.MoreObjects;
2425
import java.io.Serializable;
26+
import java.util.Collections;
27+
import java.util.List;
2528
import java.util.Objects;
2629

2730
/** This class represents the schema for a Google BigQuery Table or data source. */
@@ -90,6 +93,10 @@ TableSchema toPb() {
9093
}
9194

9295
static Schema fromPb(com.google.api.services.bigquery.model.TableSchema tableSchemaPb) {
93-
return Schema.of(FieldList.fromPb(tableSchemaPb.getFields()));
96+
List<TableFieldSchema> fields = tableSchemaPb.getFields();
97+
if (fields == null) {
98+
fields = Collections.emptyList();
99+
}
100+
return Schema.of(FieldList.fromPb(fields));
94101
}
95102
}

branches/autosynth-logging/google-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/SchemaTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import static org.junit.Assert.assertEquals;
2020

21+
import com.google.api.services.bigquery.model.TableSchema;
2122
import com.google.common.collect.ImmutableList;
2223
import java.util.List;
2324
import org.junit.Test;
@@ -57,4 +58,11 @@ private void compareTableSchema(Schema expected, Schema value) {
5758
assertEquals(expected, value);
5859
assertEquals(expected.getFields(), value.getFields());
5960
}
61+
62+
@Test
63+
public void testEmptySchema() {
64+
TableSchema tableSchema = new TableSchema();
65+
Schema schema = Schema.fromPb(tableSchema);
66+
assertEquals(0, schema.getFields().size());
67+
}
6068
}

0 commit comments

Comments
 (0)