---

andreamlin · web-flow · commit 3f8e2d4cb76e · 2019-02-22T08:50:48.000-08:00
yaml --- r: 18885 b: refs/heads/autosynth-vision c: 6300b45 h: refs/heads/master i: 18883: 1f74289
diff --git a/[refs] b/[refs]
@@ -117,7 +117,7 @@ refs/heads/autosynth-container: f6384095f50b31bfc8208542a49181e158d3681c
 refs/heads/autosynth-monitoring: 832528c131ac32b115fd7a369701d9e6e4ec62e5
 refs/heads/autosynth-pubsub: 7a327eaed5fb2a5d6c1691feb73c3e0194dd805e
 refs/heads/autosynth-video-intelligence: 53ca56e5d077bf67065b730f3fe621f40689fb4c
-refs/heads/autosynth-vision: 4aef34d3fcaaa3d8f9ac1d0bea04208d175d839f
+refs/heads/autosynth-vision: 6300b452d3c54c9a68f36e142ee3efeca66842c9
 refs/heads/spanner: b01127f885b4611bf1852abb0ce481eeb7fcc131
 refs/tags/v0.68.0: 9cc799fcf68c82ab431d425fefa58ef615ce8e5b
 refs/tags/v0.69.0: 78f67a29e8b9c46ba01de566a2eae0fd1c03edea
diff --git a/branches/autosynth-vision/google-cloud-clients/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/it/ITComputeTest.java b/branches/autosynth-vision/google-cloud-clients/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/it/ITComputeTest.java
@@ -16,9 +16,11 @@
 package com.google.cloud.compute.v1.it;
 
 import static com.google.common.truth.Truth.assertThat;
+import static junit.framework.TestCase.fail;
 
 import com.google.api.gax.core.FixedCredentialsProvider;
 import com.google.api.gax.paging.Page;
+import com.google.api.gax.rpc.InvalidArgumentException;
 import com.google.auth.Credentials;
 import com.google.auth.oauth2.GoogleCredentials;
 import com.google.cloud.ServiceOptions;
@@ -27,10 +29,14 @@
 import com.google.cloud.compute.v1.DiskTypeClient.AggregatedListDiskTypesPagedResponse;
 import com.google.cloud.compute.v1.DiskTypeSettings;
 import com.google.cloud.compute.v1.DiskTypesScopedList;
+import com.google.cloud.compute.v1.Instance;
+import com.google.cloud.compute.v1.InstanceClient;
+import com.google.cloud.compute.v1.InstanceSettings;
 import com.google.cloud.compute.v1.ListDiskTypesHttpRequest;
 import com.google.cloud.compute.v1.ProjectName;
 import com.google.cloud.compute.v1.ProjectRegionDiskTypeName;
 import com.google.cloud.compute.v1.ProjectZoneDiskTypeName;
+import com.google.cloud.compute.v1.ProjectZoneMachineTypeName;
 import com.google.cloud.compute.v1.ProjectZoneName;
 import com.google.common.collect.Lists;
 import java.io.IOException;
@@ -52,6 +58,9 @@ public class ITComputeTest {
   private static DiskTypeClient diskTypeClient;
   private static DiskTypeSettings diskTypeSettings;
 
+  private static InstanceClient instanceClient;
+  private static InstanceSettings instanceSettings;
+
   @Rule public Timeout globalTimeout = Timeout.seconds(300);
 
   @BeforeClass
@@ -65,11 +74,18 @@ public static void beforeClass() throws IOException {
             .setCredentialsProvider(FixedCredentialsProvider.create(credentials))
             .build();
     diskTypeClient = DiskTypeClient.create(diskTypeSettings);
+
+    instanceSettings =
+        InstanceSettings.newBuilder()
+            .setCredentialsProvider(FixedCredentialsProvider.create(credentials))
+            .build();
+    instanceClient = InstanceClient.create(instanceSettings);
   }
 
   @AfterClass
   public static void tearDown() throws Exception {
     diskTypeClient.close();
+    instanceClient.close();
   }
 
   @Test
@@ -85,6 +101,26 @@ public void testGetDiskType() {
     assertThat(diskType.getDefaultDiskSizeGb()).isNotNull();
   }
 
+  @Test
+  public void testInsertInstance() {
+    String machineType =
+        ProjectZoneMachineTypeName.of("n1-standard-1", DEFAULT_PROJECT, ZONE).toString();
+    Instance instance =
+        Instance.newBuilder().setName("mytestinstancetemplate").setMachineType(machineType).build();
+    try {
+      instanceClient.insertInstance(ProjectZoneName.of(DEFAULT_PROJECT, ZONE), instance);
+    } catch (InvalidArgumentException e) {
+      // Expect a Bad Request HTTP 400 error, but it should NOT be because of a resource name
+      // problem.
+      assertThat(e.getMessage()).contains("Bad Request");
+      assertThat(e.getCause().getMessage())
+          .contains("Invalid value for field 'resource.networkInterfaces'");
+      return;
+    }
+
+    fail("Expected HTTP Bad Request to be returned, but it was not returned.");
+  }
+
   @Test
   public void testListDiskTypes() {
     Page<DiskType> diskPage =
