---

JesseLovelace · JesseLovelace · commit 3f61ce5e2396 · 2019-04-26T14:47:48.000-07:00
yaml --- r: 27659 b: refs/heads/allowcolonsinids c: 5a44af8 h: refs/heads/master i: 27657: 1df2b32 27655: d598669
diff --git a/[refs] b/[refs]
@@ -193,4 +193,4 @@ refs/heads/unignorekmstest: 6ff8941f200b6150202b2ffa8df78c1b3f43707e
 refs/tags/v0.85.0: dd1c4125c845f8f309f62f02940b738f11b1d8c2
 refs/tags/v0.86.0: adbfc3b9e67b06058e3caa5aaa4897079102d2be
 refs/tags/v0.87.0: 32837d5fc5563a2a10a1f11b054f0ea44a18df04
-refs/heads/allowcolonsinids: ac0084f2e5700a4c38c7087f1c41a9bbad8de027
+refs/heads/allowcolonsinids: 5a44af8de49d149f471a7e4ffcb19e30a0e815b1
diff --git a/branches/allowcolonsinids/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java b/branches/allowcolonsinids/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java
@@ -255,7 +255,7 @@ public String strValue() {
    * policy identities to {@code Identity} objects.
    */
   public static Identity valueOf(String identityStr) {
-    String[] info = identityStr.split(":");
+    String[] info = identityStr.split(":", 2);
     Type type = Type.valueOf(CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, info[0]));
     if (info.length == 1) {
       return new Identity(type, null);
diff --git a/branches/allowcolonsinids/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java b/branches/allowcolonsinids/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java
@@ -141,11 +141,6 @@ public void testValueOfEmpty() {
     Identity.valueOf("");
   }
 
-  @Test(expected = IllegalArgumentException.class)
-  public void testValueOfThreePart() {
-    Identity.valueOf("a:b:c");
-  }
-
   @Test
   public void testUnrecognizedToString() {
     assertEquals("a:b", Identity.valueOf("a:b").strValue());
