Skip to content

Commit 36bbe4c

Browse files
authored
more doc fixes (#1529)
1 parent 29c1b8b commit 36bbe4c

2 files changed

Lines changed: 9 additions & 17 deletions

File tree

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/Publisher.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public interface Publisher {
9191
* be delayed based on the publisher bundling options.
9292
*
9393
* <p>Depending on chosen flow control {@link #failOnFlowControlLimits option}, the returned
94-
* future might immediately fail with a {@link CloudPubsubFlowControlException} or block the
94+
* future might immediately fail with a {@link FlowController.FlowControlException} or block the
9595
* current thread until there are more resources available to publish.
9696
*
9797
* @param message the message to publish.
@@ -122,12 +122,12 @@ public interface Publisher {
122122

123123
/**
124124
* Whether to block publish calls when reaching flow control limits (see {@link
125-
* #getMaxOutstandingRequestBytes()} & {@link #getMaxOutstandingElementCount()}).
125+
* #getMaxOutstandingRequestBytes()} and {@link #getMaxOutstandingElementCount()}).
126126
*
127127
* <p>If set to false, a publish call will fail with either {@link
128-
* RequestByteMaxOutstandingReachedException} or {@link
129-
* ElementCountMaxOutstandingReachedException}, as appropriate, when flow control limits are
130-
* reached.
128+
* FlowController.MaxOutstandingRequestBytesReachedException} or {@link
129+
* FlowController.MaxOutstandingElementCountReachedException}, as appropriate, when flow control
130+
* limits are reached.
131131
*/
132132
boolean failOnFlowControlLimits();
133133

@@ -247,8 +247,8 @@ public Builder setFlowControlSettings(FlowController.Settings flowControlSetting
247247

248248
/**
249249
* Whether to fail publish when reaching any of the flow control limits, with either a {@link
250-
* RequestByteMaxOutstandingReachedException} or {@link
251-
* ElementCountMaxOutstandingReachedException} as appropriate.
250+
* FlowController.MaxOutstandingRequestBytesReachedException} or {@link
251+
* FlowController.MaxOutstandingElementCountReachedException} as appropriate.
252252
*
253253
* <p>If set to false, then publish operations will block the current thread until the
254254
* outstanding requests go under the limits.

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubSubHelper.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,12 @@
1616

1717
package com.google.cloud.pubsub.testing;
1818

19-
import com.google.cloud.NoCredentials;
20-
import com.google.cloud.RetryParams;
19+
import com.google.cloud.ServiceOptions;
2120
import com.google.cloud.testing.BaseEmulatorHelper;
2221
import com.google.common.collect.ImmutableList;
23-
import com.google.cloud.ServiceOptions;
24-
2522
import io.grpc.ManagedChannel;
2623
import io.grpc.netty.NegotiationType;
2724
import io.grpc.netty.NettyChannelBuilder;
28-
2925
import java.io.IOException;
3026
import java.net.MalformedURLException;
3127
import java.net.URL;
@@ -35,7 +31,6 @@
3531
import java.util.UUID;
3632
import java.util.concurrent.TimeoutException;
3733
import java.util.logging.Logger;
38-
3934
import org.joda.time.Duration;
4035

4136
/**
@@ -104,10 +99,7 @@ public ManagedChannel createChannel() {
10499
.build();
105100
}
106101

107-
/**
108-
* Returns a {@link PubSubOptions} instance that sets the host to use the PubSub emulator on
109-
* localhost.
110-
*/
102+
/** Returns a {@link ServiceOptions} describing the emulator. */
111103
@Override
112104
public ServiceOptions getOptions() {
113105
throw new UnsupportedOperationException("not implemented as PubSubOptions no longer exists");

0 commit comments

Comments
 (0)