bigquery: deprecate ambiguous usage of delete in BigQuery client. (#5052)

shollyman · web-flow · commit 32551b2fa808 · 2019-05-02T15:14:07.000-07:00
Now that datasets may contain resources other than just tables,
deleting a resource using only the string identifiers without
type information is ambiguous.
diff --git a/google-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java b/google-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
@@ -673,22 +673,13 @@ public int hashCode() {
   /**
    * Deletes the requested table.
    *
-   * <p>Example of deleting a table.
-   *
-   * <pre>{@code
-   * String datasetName = "my_dataset_name";
-   * String tableName = "my_table_name";
-   * boolean deleted = bigquery.delete(datasetName, tableName);
-   * if (deleted) {
-   *   // the table was deleted
-   * } else {
-   *   // the table was not found
-   * }
-   * }</pre>
-   *
+   * @deprecated Now that BigQuery datasets contain multiple resource types, this invocation is
+   *     ambiguous. Please use more strongly typed version of {@code #delete} that leverages an
+   *     non-ambiguous resource type identifier such as {@code TableId}.
    * @return {@code true} if table was deleted, {@code false} if it was not found
    * @throws BigQueryException upon failure
    */
+  @Deprecated
   boolean delete(String datasetId, String tableId);
 
   /**
