hide Publisher and Subscriber's getStats() (#1555)

pongad · web-flow · commit 302a93777369 · 2017-01-24T12:02:34.000+11:00
* hide Publisher and Subscriber's getStats()

The methods are not yet implemented,
so there is no reason to expose it.
Another way out is to delete it for the time being.

* delete the methods
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java
@@ -468,12 +468,6 @@ public boolean failOnFlowControlLimits() {
     return failOnFlowControlLimits;
   }
 
-  /** Retrieves a snapshot of the publisher current {@link PublisherStats statistics}. */
-  public PublisherStats getStats() {
-    // TODO: Implement this.
-    throw new UnsupportedOperationException();
-  }
-
   /**
    * Schedules immediate publishing of any outstanding messages and waits until all are processed.
    *
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java
@@ -23,7 +23,7 @@
  * Publisher}.
  */
 @AutoValue
-public abstract class PublisherStats {
+abstract class PublisherStats {
   /** Number of successfully published messages. */
   public abstract long getAckedMessages();
 
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -365,11 +365,6 @@ public void run() {
     }
   }
 
-  public SubscriberStats getStats() {
-    // TODO: Implement me
-    return null;
-  }
-
   /** Subscription which the subscriber is subscribed to. */
   public String getSubscription() {
     return subscription;
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java
@@ -23,8 +23,8 @@
  * Subscriber}.
  */
 @AutoValue
-public abstract class SubscriberStats {
-  
+abstract class SubscriberStats {
+
   @AutoValue
   //TODO: Finish implementation.
   public abstract static class Stats {}

Original file line number	Diff line number	Diff line change
`@@ -468,12 +468,6 @@ public boolean failOnFlowControlLimits() {`
`468`	`468`	`return failOnFlowControlLimits;`
`469`	`469`	`}`
`470`	`470`
`471`		`- /** Retrieves a snapshot of the publisher current {@link PublisherStats statistics}. */`
`472`		`- public PublisherStats getStats() {`
`473`		`- // TODO: Implement this.`
`474`		`- throw new UnsupportedOperationException();`
`475`		`- }`
`476`		`-`
`477`	`471`	`/**`
`478`	`472`	`* Schedules immediate publishing of any outstanding messages and waits until all are processed.`
`479`	`473`	`*`
Original file line number	Diff line number	Diff line change
`@@ -365,11 +365,6 @@ public void run() {`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`
`368`		`- public SubscriberStats getStats() {`
`369`		`- // TODO: Implement me`
`370`		`- return null;`
`371`		`- }`
`372`		`-`
`373`	`368`	`/** Subscription which the subscriber is subscribed to. */`
`374`	`369`	`public String getSubscription() {`
`375`	`370`	`return subscription;`