Skip to content

Commit 2ab7bf1

Browse files
authored
---
yaml --- r: 32337 b: refs/heads/autosynth-errorreporting c: d2f0bc6 h: refs/heads/master i: 32335: 2e5fc67
1 parent 1d34708 commit 2ab7bf1

2 files changed

Lines changed: 16 additions & 8 deletions

File tree

  • branches/autosynth-errorreporting/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ refs/heads/autosynth-bigtable-admin: 6379a2bc712f2736c83de0e009b4d26da4fa82ca
129129
refs/heads/autosynth-containeranalysis: 18d210f81f17cf74864d0db2c29e834302f74f2a
130130
refs/heads/autosynth-datastore: f1efc3dc465174f41041acd56cf29badcec3e5bd
131131
refs/heads/autosynth-dialogflow: 73974cc32e5212aec0126472e0bc1442886fedaf
132-
refs/heads/autosynth-errorreporting: ff068a98c01b31c9cd416ff92e71c96ababcd204
132+
refs/heads/autosynth-errorreporting: d2f0bc64a53049040fe9c9d338b12fab3dd1ad6a
133133
refs/heads/autosynth-firestore: 983c75e4fb1076502c8cac73ef0538bdb10884f3
134134
refs/heads/autosynth-iot: 4025d1804241e74d54950a324dc4f667aeaad4b3
135135
refs/heads/autosynth-kms: 6b65b0f34c12d141031c7288cdc01e550212d0f6

branches/autosynth-errorreporting/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -272,13 +272,13 @@ public void publishAllOutstanding() {
272272
}
273273

274274
private ApiFuture<PublishResponse> publishCall(OutstandingBatch outstandingBatch) {
275-
PublishRequest.Builder publishRequest = PublishRequest.newBuilder();
276-
publishRequest.setTopic(topicName);
277-
for (OutstandingPublish outstandingPublish : outstandingBatch.outstandingPublishes) {
278-
publishRequest.addMessages(outstandingPublish.message);
279-
}
280-
281-
return publisherStub.publishCallable().futureCall(publishRequest.build());
275+
return publisherStub
276+
.publishCallable()
277+
.futureCall(
278+
PublishRequest.newBuilder()
279+
.setTopic(topicName)
280+
.addAllMessages(outstandingBatch.getMessages())
281+
.build());
282282
}
283283

284284
private void publishOutstandingBatch(final OutstandingBatch outstandingBatch) {
@@ -342,6 +342,14 @@ private static final class OutstandingBatch {
342342
int size() {
343343
return outstandingPublishes.size();
344344
}
345+
346+
private List<PubsubMessage> getMessages() {
347+
List<PubsubMessage> results = new ArrayList<>(outstandingPublishes.size());
348+
for (OutstandingPublish outstandingPublish : outstandingPublishes) {
349+
results.add(outstandingPublish.message);
350+
}
351+
return results;
352+
}
345353
}
346354

347355
private static final class OutstandingPublish {

0 commit comments

Comments
 (0)