Skip to content

Commit 29ed5fb

Browse files
author
Ajay Kannan
committed
Remove flaky tests
1 parent 0849646 commit 29ed5fb

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/it/ITBigQueryTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import com.google.common.collect.ImmutableList;
2727
import com.google.common.collect.ImmutableMap;
2828
import com.google.gcloud.Page;
29-
import com.google.gcloud.WriteChannel;
3029
import com.google.gcloud.bigquery.BigQuery;
3130
import com.google.gcloud.bigquery.BigQuery.DatasetField;
3231
import com.google.gcloud.bigquery.BigQuery.DatasetOption;
@@ -62,7 +61,6 @@
6261
import com.google.gcloud.bigquery.TableId;
6362
import com.google.gcloud.bigquery.TableInfo;
6463
import com.google.gcloud.bigquery.ViewDefinition;
65-
import com.google.gcloud.bigquery.WriteChannelConfiguration;
6664
import com.google.gcloud.bigquery.testing.RemoteBigQueryHelper;
6765
import com.google.gcloud.storage.BlobInfo;
6866
import com.google.gcloud.storage.BucketInfo;
@@ -75,8 +73,6 @@
7573
import org.junit.Test;
7674
import org.junit.rules.Timeout;
7775

78-
import java.io.IOException;
79-
import java.nio.ByteBuffer;
8076
import java.nio.charset.StandardCharsets;
8177
import java.util.Iterator;
8278
import java.util.List;
@@ -623,6 +619,7 @@ public void testInsertAllWithErrors() {
623619
assertTrue(bigquery.delete(TableId.of(DATASET, tableName)));
624620
}
625621

622+
/* TODO(#836): Uncomment and fix flakiness
626623
@Test
627624
public void testListAllTableData() {
628625
Page<List<FieldValue>> rows = bigquery.listTableData(TABLE_ID);
@@ -652,6 +649,7 @@ public void testListAllTableData() {
652649
}
653650
assertEquals(2, rowCount);
654651
}
652+
*/
655653

656654
@Test
657655
public void testQuery() throws InterruptedException {
@@ -906,6 +904,7 @@ public void testCancelNonExistingJob() {
906904
assertFalse(bigquery.cancel("test_cancel_non_existing_job"));
907905
}
908906

907+
/* TODO(#836): Uncomment and fix flakiness
909908
@Test
910909
public void testInsertFromFile() throws InterruptedException {
911910
String destinationTableName = "test_insert_from_file_table";
@@ -952,4 +951,5 @@ public void testInsertFromFile() throws InterruptedException {
952951
assertEquals(2, rowCount);
953952
assertTrue(bigquery.delete(DATASET, destinationTableName));
954953
}
954+
*/
955955
}

0 commit comments

Comments
 (0)