Skip to content

Commit 246550d

Browse files
gremi64sduskis
authored andcommitted
---
yaml --- r: 19193 b: refs/heads/autosynth-bigquerystorage c: 64f3b2b h: refs/heads/master i: 19191: 95c8ea8
1 parent 2a3cfe2 commit 246550d

3 files changed

Lines changed: 16 additions & 1 deletion

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ refs/tags/v0.69.0: 78f67a29e8b9c46ba01de566a2eae0fd1c03edea
124124
refs/heads/autosynth-asset: cd8251de8c40e239ad24dcf9ed93ea2708a3eed5
125125
refs/heads/autosynth-automl: 2a8b018cf05811fd472e5d1053e67a12ceec0b64
126126
refs/heads/autosynth-bigquerydatatransfer: 564833a85642d4194adc025f021e10e723154246
127-
refs/heads/autosynth-bigquerystorage: bb2bb7cff5766d2070a8421d902e4af1c9c18bac
127+
refs/heads/autosynth-bigquerystorage: 64f3b2be23eab15df420e5890f14409fa52c8411
128128
refs/heads/autosynth-bigtable: 2fbcb15847e0e89e79d6dc07420e28d7dfcea894
129129
refs/heads/autosynth-bigtable-admin: 6379a2bc712f2736c83de0e009b4d26da4fa82ca
130130
refs/heads/autosynth-containeranalysis: 039ca5b8db725c76c16a965ff26b2774322b8ef8

branches/autosynth-bigquerystorage/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -664,4 +664,9 @@ public List<WriteResult> apply(CommitResponse commitResponse) {
664664
boolean isEmpty() {
665665
return mutations.isEmpty();
666666
}
667+
668+
/** Get the number of mutations. */
669+
public int getMutationsSize() {
670+
return mutations.size();
671+
}
667672
}

branches/autosynth-bigquerystorage/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/WriteBatchTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ public void updateDocument() throws Exception {
9191
batch.update(documentReference, updateTime, "foo", "bar");
9292
batch.update(documentReference, LocalFirestoreHelper.SINGLE_FIELD_MAP, updateTime);
9393

94+
assertEquals(4, batch.getMutationsSize());
95+
9496
List<WriteResult> writeResults = batch.commit().get();
9597
List<Write> writes = new ArrayList<>();
9698

@@ -126,6 +128,8 @@ public void setDocument() throws Exception {
126128
writes.add(set(LocalFirestoreHelper.SINGLE_FIELD_PROTO, Arrays.asList("foo")));
127129
writes.add(set(LocalFirestoreHelper.SINGLE_FIELD_PROTO, Arrays.asList("foo")));
128130

131+
assertEquals(4, batch.getMutationsSize());
132+
129133
List<WriteResult> writeResults = batch.commit().get();
130134
for (int i = 0; i < writeResults.size(); ++i) {
131135
assertEquals(Timestamp.ofTimeSecondsAndNanos(i, i), writeResults.get(i).getUpdateTime());
@@ -144,6 +148,8 @@ public void omitWriteResultForDocumentTransforms() throws Exception {
144148

145149
batch.set(documentReference, map("time", FieldValue.serverTimestamp()));
146150

151+
assertEquals(1, batch.getMutationsSize());
152+
147153
List<WriteResult> writeResults = batch.commit().get();
148154
assertEquals(1, writeResults.size());
149155
}
@@ -159,6 +165,8 @@ public void createDocument() throws Exception {
159165
.create(documentReference, LocalFirestoreHelper.SINGLE_FIELD_MAP)
160166
.create(documentReference, LocalFirestoreHelper.SINGLE_FIELD_OBJECT);
161167

168+
assertEquals(2, batch.getMutationsSize());
169+
162170
List<WriteResult> writeResults = batch.commit().get();
163171
List<Write> writes = new ArrayList<>();
164172

@@ -188,6 +196,8 @@ public void deleteDocument() throws Exception {
188196
precondition.getUpdateTimeBuilder().setSeconds(1).setNanos(2);
189197
writes.add(delete(precondition.build()));
190198

199+
assertEquals(2, batch.getMutationsSize());
200+
191201
List<WriteResult> writeResults = batch.commit().get();
192202

193203
for (int i = 0; i < writeResults.size(); ++i) {

0 commit comments

Comments
 (0)