Fix response code retrying logic for HTTP responses with "Content-Type" other than "application/json". (#2329)

vam-google · web-flow · commit 22e542358bb0 · 2017-08-10T17:29:03.000-07:00
diff --git a/google-cloud-core-http/src/main/java/com/google/cloud/http/BaseHttpServiceException.java b/google-cloud-core-http/src/main/java/com/google/cloud/http/BaseHttpServiceException.java
@@ -62,6 +62,7 @@ private static ExceptionData makeExceptionData(IOException exception, boolean id
           }
         } else {
           code = ((GoogleJsonResponseException) exception).getStatusCode();
+          retryable = BaseServiceException.isRetryable(code, null, idempotent, retryableErrors);
         }
       } else {
         // In cases where an exception is an instance of HttpResponseException but not

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ private static ExceptionData makeExceptionData(IOException exception, boolean id`
`62`	`62`	`}`
`63`	`63`	`} else {`
`64`	`64`	`code = ((GoogleJsonResponseException) exception).getStatusCode();`
	`65`	`+ retryable = BaseServiceException.isRetryable(code, null, idempotent, retryableErrors);`
`65`	`66`	`}`
`66`	`67`	`} else {`
`67`	`68`	`// In cases where an exception is an instance of HttpResponseException but not`