---

sduskis · web-flow · commit 21aefc0d5ac5 · 2019-05-30T12:52:27.000-04:00
yaml --- r: 33283 b: refs/heads/autosynth-language c: 28b211f h: refs/heads/master i: 33281: f895746 33279: 03db471
diff --git a/[refs] b/[refs]
@@ -133,7 +133,7 @@ refs/heads/autosynth-errorreporting: effe8001d110ad584187b30aafc473db0dd4a15f
 refs/heads/autosynth-firestore: e79eeb26930dfae4439424ad2fda5874eeca54c8
 refs/heads/autosynth-iot: 044be280805a59e06d09658688c9ee474a9815ad
 refs/heads/autosynth-kms: d31449d6621a50fb16a4bef4f30f0f3051d27d7c
-refs/heads/autosynth-language: 248ace9e690c7a5e00475a4b895b837fb63beb2f
+refs/heads/autosynth-language: 28b211fe52ced1e256561eac518047a10676dde0
 refs/heads/autosynth-os-login: 123ba209c5769d0ee067e0ce5848bec13b42a4f4
 refs/heads/autosynth-redis: 6bedce4d7c7c6ca6a22e83ad1780e08fdc565a9e
 refs/heads/autosynth-scheduler: 57f9fdb1e7de30c85f4ec7198931a07f50603e55
diff --git a/branches/autosynth-language/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java b/branches/autosynth-language/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
@@ -29,7 +29,6 @@
 import com.google.api.gax.core.CredentialsProvider;
 import com.google.api.gax.core.Distribution;
 import com.google.api.gax.core.ExecutorProvider;
-import com.google.api.gax.core.FixedExecutorProvider;
 import com.google.api.gax.core.InstantiatingExecutorProvider;
 import com.google.api.gax.rpc.HeaderProvider;
 import com.google.api.gax.rpc.NoHeaderProvider;
@@ -41,12 +40,15 @@
 import com.google.cloud.pubsub.v1.stub.SubscriberStubSettings;
 import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import com.google.pubsub.v1.ProjectSubscriptionName;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.annotation.Nullable;
@@ -138,13 +140,8 @@ private Subscriber(Builder builder) {
     executorProvider = builder.executorProvider;
 
     ExecutorProvider systemExecutorProvider = builder.systemExecutorProvider;
-    if (systemExecutorProvider == null) {
-      systemExecutorProvider =
-          FixedExecutorProvider.create(
-              Executors.newScheduledThreadPool(Math.max(6, 2 * numPullers)));
-    }
-
     alarmsExecutor = systemExecutorProvider.getExecutor();
+
     if (systemExecutorProvider.shouldAutoClose()) {
       closeables.add(
           new AutoCloseable() {
@@ -405,6 +402,7 @@ public static final class Builder {
         InstantiatingExecutorProvider.newBuilder()
             .setExecutorThreadCount(THREADS_PER_CHANNEL)
             .build();
+    private static final AtomicInteger SYSTEM_EXECUTOR_COUNTER = new AtomicInteger();
 
     private String subscriptionName;
     private MessageReceiver receiver;
@@ -543,6 +541,28 @@ Builder setClock(ApiClock clock) {
     }
 
     public Subscriber build() {
+      if (systemExecutorProvider == null) {
+        ThreadFactory threadFactory =
+            new ThreadFactoryBuilder()
+                .setDaemon(true)
+                .setNameFormat("Subscriber-SE-" + SYSTEM_EXECUTOR_COUNTER.incrementAndGet() + "-%d")
+                .build();
+        int threadCount = Math.max(6, 2 * parallelPullCount);
+        final ScheduledExecutorService executor =
+            Executors.newScheduledThreadPool(threadCount, threadFactory);
+        systemExecutorProvider =
+            new ExecutorProvider() {
+              @Override
+              public boolean shouldAutoClose() {
+                return true;
+              }
+
+              @Override
+              public ScheduledExecutorService getExecutor() {
+                return executor;
+              }
+            };
+      }
       return new Subscriber(this);
     }
   }
