Skip to content

Commit 2095f4a

Browse files
authored
fix: Expose Gax meter name (#2865)
This can mitigate the ask to expose `Meter` as a constructor parameter in `OpenTelemetryMetricsRecorder`. Since `Meter` usually represents the libary that does the instrumentation, we can not expose it. However, we can expose the meter name as a public String, so that users of gax can create Otel views more easily with it.
1 parent 8d31c05 commit 2095f4a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/OpenTelemetryMetricsRecorder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
@BetaApi
5656
@InternalApi
5757
public class OpenTelemetryMetricsRecorder implements MetricsRecorder {
58+
59+
public static final String GAX_METER_NAME = "gax-java";
5860
private final DoubleHistogram attemptLatencyRecorder;
5961
private final DoubleHistogram operationLatencyRecorder;
6062
private final LongCounter operationCountRecorder;
@@ -76,7 +78,7 @@ public class OpenTelemetryMetricsRecorder implements MetricsRecorder {
7678
public OpenTelemetryMetricsRecorder(OpenTelemetry openTelemetry, String serviceName) {
7779
Meter meter =
7880
openTelemetry
79-
.meterBuilder("gax-java")
81+
.meterBuilder(GAX_METER_NAME)
8082
.setInstrumentationVersion(GaxProperties.getGaxVersion())
8183
.build();
8284
this.attemptLatencyRecorder =

0 commit comments

Comments
 (0)