---

sduskis · web-flow · commit 1f1368c63b13 · 2019-04-18T10:11:44.000-04:00
yaml --- r: 32299 b: refs/heads/autosynth-errorreporting c: 8894854 h: refs/heads/master i: 32297: 5ddbd87 32295: 11dd7a2
diff --git a/[refs] b/[refs]
@@ -129,7 +129,7 @@ refs/heads/autosynth-bigtable-admin: 6379a2bc712f2736c83de0e009b4d26da4fa82ca
 refs/heads/autosynth-containeranalysis: 18d210f81f17cf74864d0db2c29e834302f74f2a
 refs/heads/autosynth-datastore: f1efc3dc465174f41041acd56cf29badcec3e5bd
 refs/heads/autosynth-dialogflow: 73974cc32e5212aec0126472e0bc1442886fedaf
-refs/heads/autosynth-errorreporting: 909d0944c96347814c3ec56cb36fbd0c14f700a1
+refs/heads/autosynth-errorreporting: 8894854f9bcd487769ad9f38ce441a88577a4cf3
 refs/heads/autosynth-firestore: 983c75e4fb1076502c8cac73ef0538bdb10884f3
 refs/heads/autosynth-iot: 4025d1804241e74d54950a324dc4f667aeaad4b3
 refs/heads/autosynth-kms: 6b65b0f34c12d141031c7288cdc01e550212d0f6
diff --git a/branches/autosynth-errorreporting/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/branches/autosynth-errorreporting/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -304,15 +304,18 @@ public void publishAllOutstanding() {
     publishOutstandingBatch(batchToSend);
   }
 
-  private void publishOutstandingBatch(final OutstandingBatch outstandingBatch) {
+  private ApiFuture<PublishResponse> publishCall(OutstandingBatch outstandingBatch) {
     PublishRequest.Builder publishRequest = PublishRequest.newBuilder();
     publishRequest.setTopic(topicName);
     for (OutstandingPublish outstandingPublish : outstandingBatch.outstandingPublishes) {
       publishRequest.addMessages(outstandingPublish.message);
     }
 
-    ApiFutures.addCallback(
-        publisherStub.publishCallable().futureCall(publishRequest.build()),
+    return publisherStub.publishCallable().futureCall(publishRequest.build());
+  }
+
+  private void publishOutstandingBatch(final OutstandingBatch outstandingBatch) {
+    ApiFutureCallback<PublishResponse> futureCallback =
         new ApiFutureCallback<PublishResponse>() {
           @Override
           public void onSuccess(PublishResponse result) {
@@ -351,8 +354,9 @@ public void onFailure(Throwable t) {
               messagesWaiter.incrementPendingMessages(-outstandingBatch.size());
             }
           }
-        },
-        directExecutor());
+        };
+
+    ApiFutures.addCallback(publishCall(outstandingBatch), futureCallback, directExecutor());
   }
 
   private static final class OutstandingBatch {
