---

schmidt-sebastian · pongad · commit 1c43b60609ca · 2018-04-26T11:32:37.000-07:00
yaml --- r: 9413 b: refs/heads/spanner-gapic-migration c: 412cf0d h: refs/heads/master i: 9411: 4669b76
diff --git a/[refs] b/[refs]
@@ -80,7 +80,7 @@ refs/tags/v0.34.0: bf31760a31a66acb239322a70dcd03dbe1d0c7ca
 refs/tags/v0.35.0: c28951c5f4cc97a1be07900d19df6984115a4bd6
 refs/tags/v0.36.0: 6b75c61f73e6827b3ca379bd54f88f750290162f
 refs/tags/v0.37.0: db2e142f92601709fdd48db159776f905742e30f
-refs/heads/spanner-gapic-migration: c001e14a6119affebd94dcbcc715509392d2c527
+refs/heads/spanner-gapic-migration: 412cf0df77c4ea55e4e85a545f622ff4f14db0b4
 refs/tags/v0.38.0: c235ee4df5e1248e1769dae3f86a0d7ab7fd8301
 refs/tags/v0.39.0: ab231c9d22475242a43d6d9554aa4a3f736dab01
 refs/tags/v0.40.0: a1d5b05206cce7734365f1b910396a2c9d6605ec
diff --git a/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java b/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java
@@ -26,9 +26,13 @@
 
 /**
  * A CollectionReference can be used for adding documents, getting document references, and querying
- * for documents (using the methods inherited from Query)
+ * for documents (using the methods inherited from Query).
+ *
+ * <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
+ * test mocks. Subclassing is not supported in production code and new SDK releases may break code
+ * that does so.
  */
-public final class CollectionReference extends Query {
+public class CollectionReference extends Query {
 
   /**
    * Creates a CollectionReference from a complete collection path.
diff --git a/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentReference.java b/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentReference.java
@@ -36,8 +36,12 @@
  * write, read, or listen to the location. There may or may not exist a document at the referenced
  * location. A DocumentReference can also be used to create a CollectionReference to a
  * subcollection.
+ *
+ * <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
+ * test mocks. Subclassing is not supported in production code and new SDK releases may break code
+ * that does so.
  */
-public final class DocumentReference {
+public class DocumentReference {
 
   private final ResourcePath path;
   private final FirestoreImpl firestore;
diff --git a/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java b/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java
@@ -41,6 +41,10 @@
  * <p>If the DocumentSnapshot points to a non-existing document, getData() and its corresponding
  * methods will return null. You can always explicitly check for a document's existence by calling
  * {@link #exists()}.
+ *
+ * <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
+ * test mocks. Subclassing is not supported in production code and new SDK releases may break code
+ * that does so.
  */
 public class DocumentSnapshot {
 
diff --git a/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java b/branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java
@@ -32,8 +32,12 @@
  * <p>QueryDocumentSnapshot offers the same API surface as {@link DocumentSnapshot}. Since query
  * results contain only existing documents, the {@link #exists()} method will always return true and
  * {@code getData()} will never be null.
+ *
+ * <p><b>Subclassing Note</b>: Firestore classes are not meant to be subclassed except for use in
+ * test mocks. Subclassing is not supported in production code and new SDK releases may break code
+ * that does so.
  */
-public final class QueryDocumentSnapshot extends DocumentSnapshot {
+public class QueryDocumentSnapshot extends DocumentSnapshot {
   private QueryDocumentSnapshot(
       FirestoreImpl firestore,
       DocumentReference docRef,
