Adding Cloud Bigtable Mutation fromProto (#4461)

sduskis · web-flow · commit 1baa6023966a · 2019-02-07T20:52:13.000-05:00
* Adding Cloud Bigtable Mutation fromProto

* Fixing formatting

* Addressing comments
`fromProto` becomes `fromProtoUnsafe`

* Fixing lint issues.

* adding a warning to `fromProtoUnsafe`
diff --git a/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java b/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
@@ -73,6 +73,19 @@ public static Mutation createUnsafe() {
     return new Mutation(true);
   }
 
+  /**
+   * Wraps the List of protobuf {@link com.google.bigtable.v2.Mutation}. This methods, like {@link
+   * #createUnsafe()}, allows setCell operation to use server side timestamp. This is dangerous
+   * because mutations will no longer be idempotent, which might cause multiple duplicate values to
+   * be stored in Bigtable. This option should only be used for advanced usecases with extreme care.
+   */
+  @BetaApi
+  public static Mutation fromProtoUnsafe(List<com.google.bigtable.v2.Mutation> protos) {
+    Mutation mutation = new Mutation(true);
+    mutation.mutations.addAll(protos);
+    return mutation;
+  }
+
   private Mutation(boolean allowServersideTimestamp) {
     this.allowServersideTimestamp = allowServersideTimestamp;
   }
diff --git a/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java b/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java
@@ -95,6 +95,8 @@ public void setCellTest() {
     assertThat(actual.get(3).getSetCell().getValue())
         .isEqualTo(ByteString.copyFromUtf8("fake-value2"));
     assertThat(actual.get(3).getSetCell().getTimestampMicros()).isIn(expectedTimestampRange);
+
+    assertThat(Mutation.fromProtoUnsafe(actual).getMutations()).isEqualTo(actual);
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,8 @@ public void setCellTest() {`
`95`	`95`	`assertThat(actual.get(3).getSetCell().getValue())`
`96`	`96`	`.isEqualTo(ByteString.copyFromUtf8("fake-value2"));`
`97`	`97`	`assertThat(actual.get(3).getSetCell().getTimestampMicros()).isIn(expectedTimestampRange);`
	`98`	`+`
	`99`	`+ assertThat(Mutation.fromProtoUnsafe(actual).getMutations()).isEqualTo(actual);`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`@Test`