pubsub: make poll wait for messages (#2112)

pongad · web-flow · commit 19cc97d36e26 · 2017-06-06T13:40:07.000+10:00
Instead of returning immediately if no messages are available, poll now waits for messages. Fixes #2108.
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java
@@ -131,13 +131,12 @@ private void pullMessages(final Duration backoff) {
       return;
     }
     ListenableFuture<PullResponse> pullResult =
-        stub.withDeadlineAfter(DEFAULT_TIMEOUT.toMillis(), TimeUnit.MILLISECONDS)
-            .pull(
-                PullRequest.newBuilder()
-                    .setSubscription(subscription)
-                    .setMaxMessages(maxDesiredPulledMessages)
-                    .setReturnImmediately(true)
-                    .build());
+        stub.pull(
+            PullRequest.newBuilder()
+                .setSubscription(subscription)
+                .setMaxMessages(maxDesiredPulledMessages)
+                .setReturnImmediately(false)
+                .build());
 
     Futures.addCallback(
         pullResult,
