Skip to content

Commit 1985918

Browse files
committed
datastore: force import grpc-google-common-protos:0.1.9
Also removes grpc-all dependency from top-level pom.xml; it is unused. Datastore is tested with `mvn verify`. Depedency versions are shown to not conflict by creating and compiling a test project that depends only on google-cloud. Since it does not inherit the version resolution from google-cloud-java/pom.xml, it more closely resembles user project.
1 parent 750d127 commit 1985918

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

google-cloud-datastore/pom.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,16 @@
3838
<version>1.3.0</version>
3939
<exclusions>
4040
<exclusion>
41-
<artifactId>guava-jdk5</artifactId>
4241
<groupId>com.google.guava</groupId>
42+
<artifactId>guava-jdk5</artifactId>
4343
</exclusion>
4444
</exclusions>
4545
</dependency>
46+
<dependency>
47+
<groupId>com.google.api.grpc</groupId>
48+
<artifactId>grpc-google-common-protos</artifactId>
49+
<version>0.1.9</version>
50+
</dependency>
4651
<dependency>
4752
<groupId>${project.groupId}</groupId>
4853
<artifactId>google-cloud-core</artifactId>

pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -466,11 +466,6 @@
466466
<artifactId>grpc-protobuf</artifactId>
467467
<version>${grpc.version}</version>
468468
</dependency>
469-
<dependency>
470-
<groupId>io.grpc</groupId>
471-
<artifactId>grpc-all</artifactId>
472-
<version>${grpc.version}</version>
473-
</dependency>
474469
<dependency>
475470
<groupId>joda-time</groupId>
476471
<artifactId>joda-time</artifactId>

0 commit comments

Comments
 (0)