Address comments

Frank Natividad · Frank Natividad · commit 116220c0220e · 2018-05-07T10:28:27.000-07:00
diff --git a/google-cloud-storage/pom.xml b/google-cloud-storage/pom.xml
@@ -29,7 +29,6 @@
     <dependency>
       <groupId>com.google.apis</groupId>
       <artifactId>google-api-services-storage</artifactId>
-      <version>v1-rev125-1.23.0</version>
       <scope>compile</scope>
       <exclusions>
         <exclusion>
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/Blob.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/Blob.java
@@ -402,6 +402,7 @@ Builder setCustomerEncryption(CustomerEncryption customerEncryption) {
       return this;
     }
 
+    @GcpLaunchStage.Beta
     @Override
     public Builder setKmsKeyName(String kmsKeyName) {
       infoBuilder.setKmsKeyName(kmsKeyName);
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java
@@ -24,6 +24,7 @@
 import com.google.api.services.storage.model.ObjectAccessControl;
 import com.google.api.services.storage.model.StorageObject;
 import com.google.api.services.storage.model.StorageObject.Owner;
+import com.google.cloud.GcpLaunchStage;
 import com.google.cloud.storage.Blob.Builder;
 import com.google.common.base.Function;
 import com.google.common.base.MoreObjects;
@@ -271,6 +272,7 @@ public abstract static class Builder {
      *
      * Sets the blob's kmsKeyName.
      */
+    @GcpLaunchStage.Beta
     public abstract Builder setKmsKeyName(String kmsKeyName);
 
     /**
@@ -484,6 +486,7 @@ Builder setCustomerEncryption(CustomerEncryption customerEncryption) {
       return this;
     }
 
+    @GcpLaunchStage.Beta
     @Override
     public Builder setKmsKeyName(String kmsKeyName) {
       this.kmsKeyName = kmsKeyName;
@@ -756,6 +759,7 @@ public StorageClass getStorageClass() {
   /**
    * Returns the Cloud KMS key used to encrypt the blob, if any.
    */
+  @GcpLaunchStage.Beta
   public String getKmsKeyName() {
     return kmsKeyName;
   }
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/Bucket.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/Bucket.java
@@ -612,6 +612,7 @@ public Builder setLabels(Map<String, String> labels) {
       return this;
     }
 
+    @GcpLaunchStage.Beta
     @Override
     public Builder setDefaultKmsKeyName(String defaultKmsKeyName) {
       infoBuilder.setDefaultKmsKeyName(defaultKmsKeyName);
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
@@ -31,6 +31,7 @@
 import com.google.api.services.storage.model.Bucket.Owner;
 import com.google.api.services.storage.model.Bucket.Versioning;
 import com.google.api.services.storage.model.Bucket.Website;
+import com.google.cloud.GcpLaunchStage;
 import com.google.cloud.storage.Acl.Entity;
 import com.google.common.base.Function;
 import com.google.common.base.MoreObjects;
@@ -428,6 +429,7 @@ public abstract static class Builder {
     /**
      * Sets the default Cloud KMS key name for this bucket.
      */
+    @GcpLaunchStage.Beta
     public abstract Builder setDefaultKmsKeyName(String defaultKmsKeyName);
 
     /**
@@ -593,6 +595,7 @@ public Builder setLabels(Map<String, String> labels) {
       return this;
     }
 
+    @GcpLaunchStage.Beta
     @Override
     public Builder setDefaultKmsKeyName(String defaultKmsKeyName) {
       this.defaultKmsKeyName = defaultKmsKeyName != null
@@ -782,6 +785,7 @@ public Map<String, String> getLabels() {
   /**
    * Returns the default Cloud KMS key to be applied to newly inserted objects in this bucket.
    */
+  @GcpLaunchStage.Beta
   public String getDefaultKmsKeyName() {
     return defaultKmsKeyName;
   }
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java
@@ -82,7 +82,6 @@
 import java.util.List;
 import java.util.Map;
 
-import jdk.nashorn.internal.runtime.regexp.joni.exception.ValueException;
 import org.apache.http.HttpStatus;
 
 public class HttpStorageRpc implements StorageRpc {

Original file line number	Diff line number	Diff line change
`@@ -402,6 +402,7 @@ Builder setCustomerEncryption(CustomerEncryption customerEncryption) {`
`402`	`402`	`return this;`
`403`	`403`	`}`
`404`	`404`
	`405`	`+ @GcpLaunchStage.Beta`
`405`	`406`	`@Override`
`406`	`407`	`public Builder setKmsKeyName(String kmsKeyName) {`
`407`	`408`	`infoBuilder.setKmsKeyName(kmsKeyName);`
Original file line number	Diff line number	Diff line change
`@@ -612,6 +612,7 @@ public Builder setLabels(Map<String, String> labels) {`
`612`	`612`	`return this;`
`613`	`613`	`}`
`614`	`614`
	`615`	`+ @GcpLaunchStage.Beta`
`615`	`616`	`@Override`
`616`	`617`	`public Builder setDefaultKmsKeyName(String defaultKmsKeyName) {`
`617`	`618`	`infoBuilder.setDefaultKmsKeyName(defaultKmsKeyName);`