minor fixes

Ajay Kannan · Ajay Kannan · commit 0eada880fe94 · 2015-12-21T09:15:57.000-08:00
diff --git a/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/ResourceManager.java b/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/ResourceManager.java
@@ -213,8 +213,8 @@ public static ProjectListOption fields(ProjectField... fields) {
   /**
    * Retrieves the project identified by the specified project ID.
    *
-   * <p>The caller must have read permissions for this project. Returns {@code null} if project
-   * not found.
+   * <p>Returns {@code null} if the project is not found or if the user doesn't have read
+   * permissions for the project.
    *
    * @see <a
    * href="https://cloud.google.com/resource-manager/reference/rest/v1beta1/projects/get">Cloud
diff --git a/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/DefaultResourceManagerRpc.java b/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/DefaultResourceManagerRpc.java
@@ -89,7 +89,8 @@ public Project get(String projectId, Map<Option, ?> options) throws ResourceMana
     } catch (IOException ex) {
       ResourceManagerException translated = translate(ex);
       if (translated.code() == HTTP_FORBIDDEN || translated.code() == HTTP_NOT_FOUND) {
-        return null; // Project not found
+        // Service can return either 403 or 404 to signify that the project doesn't exist.
+        return null;
       } else {
         throw translated;
       }

Original file line number	Diff line number	Diff line change
`@@ -213,8 +213,8 @@ public static ProjectListOption fields(ProjectField... fields) {`
`213`	`213`	`/**`
`214`	`214`	`* Retrieves the project identified by the specified project ID.`
`215`	`215`	`*`
`216`		`- * <p>The caller must have read permissions for this project. Returns {@code null} if project`
`217`		`- * not found.`
	`216`	`+ * <p>Returns {@code null} if the project is not found or if the user doesn't have read`
	`217`	`+ * permissions for the project.`
`218`	`218`	`*`
`219`	`219`	`* @see <a`
`220`	`220`	`* href="https://cloud.google.com/resource-manager/reference/rest/v1beta1/projects/get">Cloud`