verify.sh: make verify more debug-friendly (#2133)

pongad · web-flow · commit 0e0c7039dd99 · 2017-06-09T14:44:12.000+10:00
This commit adds two options to `maven verify`.

The first, `-fae` (fail at end) makes the tests keep going
after failures. If a test flakes, at least we'll still
see the result of other tests.

The second, `-DtrimStackTrace=false` prints full stack
trace to make debugging easier.

Finally, we dedup the command call.
diff --git a/utilities/verify.sh b/utilities/verify.sh
@@ -2,15 +2,19 @@
 # This script is used by Travis-CI to run tests.
 # This script is referenced in .travis.yml.
 
+mvn_opts="-DtrimStackTrace=false -fae --quiet -Djava.util.logging.config.file=logging.properties -P release"
+
 if [ "${TRAVIS_PULL_REQUEST}" == "false" ]; then
     source ./utilities/integration_test_env.sh
     # Get signing tools and API keyfile
     openssl aes-256-cbc -K $encrypted_631490ecae8f_key -iv $encrypted_631490ecae8f_iv -in target/travis/signing-tools.tar.enc -out $TRAVIS_BUILD_DIR/signing-tools.tar -d
     mkdir $TRAVIS_BUILD_DIR/signing-tools
     chmod 700 $TRAVIS_BUILD_DIR/signing-tools
     tar xvf $TRAVIS_BUILD_DIR/signing-tools.tar -C $TRAVIS_BUILD_DIR/signing-tools
-    # Run verify
-    mvn verify --quiet -Djava.util.logging.config.file=logging.properties -P release
 else
-    mvn verify --quiet -Djava.util.logging.config.file=logging.properties -DskipITs -P release
+    # Skip integration tests when testing pull requests.
+    mvn_opts+=" -DskipITs"
 fi
+
+# We don't quote expansion here, since we actually want space to separate the arguments.
+mvn verify $mvn_opts
