Switching from positional parameter to named parameter

garrettjonesgoogle · garrettjonesgoogle · commit 0b457c65d8fb · 2016-12-07T17:15:28.000-08:00
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java
@@ -614,12 +614,12 @@ public QueryResponse runQuery(String query) throws InterruptedException {
    * Example of running a query with query parameters.
    */
   // [TARGET query(QueryRequest)]
-  // [VARIABLE "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where word_count > ?"]
+  // [VARIABLE "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where word_count > @wordCount"]
   public QueryResponse runQueryWithParameters(String query) throws InterruptedException {
     // [START runQueryWithParameters]
     QueryRequest request = QueryRequest.newBuilder(query)
         .setUseLegacySql(false) // standard SQL is required to use query parameters
-        .addPositionalParameter(QueryParameterValue.int64(5))
+        .addNamedParameter("wordCount", QueryParameterValue.int64(5))
         .build();
     QueryResponse response = bigquery.query(request);
     // Wait for things to finish
diff --git a/google-cloud-examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITBigQuerySnippets.java b/google-cloud-examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITBigQuerySnippets.java
@@ -74,7 +74,7 @@ public class ITBigQuerySnippets {
   private static final String QUERY =
       "SELECT unique(corpus) FROM [bigquery-public-data:samples.shakespeare]";
   private static final String QUERY_WITH_PARAMETERS =
-      "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where word_count > ?";
+      "SELECT distinct(corpus) FROM `bigquery-public-data.samples.shakespeare` where word_count > @wordCount";
   private static final Function<Job, JobId> TO_JOB_ID_FUNCTION = new Function<Job, JobId>() {
     @Override
     public JobId apply(Job job) {
