---

sduskis · web-flow · commit 098f3753e328 · 2019-05-30T12:52:27.000-04:00
yaml --- r: 34535 b: refs/heads/autosynth-tasks c: 28b211f h: refs/heads/master i: 34533: 047d519 34531: 4c60008 34527: 40f4205
diff --git a/[refs] b/[refs]
@@ -139,7 +139,7 @@ refs/heads/autosynth-redis: 2b698ebe7faaa0b93246576a88941682e0888e57
 refs/heads/autosynth-scheduler: a3de6480746d1cd586ca8b9d75c55a636f371539
 refs/heads/autosynth-spanner: d963fe4368e79cf6abae5d511785e8ced8ac57f4
 refs/heads/autosynth-speech: c563dcd420cce0a37c39b1b9c24be1b9ba604dc7
-refs/heads/autosynth-tasks: 248ace9e690c7a5e00475a4b895b837fb63beb2f
+refs/heads/autosynth-tasks: 28b211fe52ced1e256561eac518047a10676dde0
 refs/heads/autosynth-texttospeech: 2c442fe0b7f089fbab266edfe4dd83c532e82dd0
 refs/heads/autosynth-trace: c94eef6e4d9c6fd24888216e28ca7271959c1cf0
 refs/heads/autosynth-websecurityscanner: fa561b356aabcd92d415ae8dc88fd8d87dbc5b23
diff --git a/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java b/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
@@ -29,7 +29,6 @@
 import com.google.api.gax.core.CredentialsProvider;
 import com.google.api.gax.core.Distribution;
 import com.google.api.gax.core.ExecutorProvider;
-import com.google.api.gax.core.FixedExecutorProvider;
 import com.google.api.gax.core.InstantiatingExecutorProvider;
 import com.google.api.gax.rpc.HeaderProvider;
 import com.google.api.gax.rpc.NoHeaderProvider;
@@ -41,12 +40,15 @@
 import com.google.cloud.pubsub.v1.stub.SubscriberStubSettings;
 import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import com.google.pubsub.v1.ProjectSubscriptionName;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.annotation.Nullable;
@@ -138,13 +140,8 @@ private Subscriber(Builder builder) {
     executorProvider = builder.executorProvider;
 
     ExecutorProvider systemExecutorProvider = builder.systemExecutorProvider;
-    if (systemExecutorProvider == null) {
-      systemExecutorProvider =
-          FixedExecutorProvider.create(
-              Executors.newScheduledThreadPool(Math.max(6, 2 * numPullers)));
-    }
-
     alarmsExecutor = systemExecutorProvider.getExecutor();
+
     if (systemExecutorProvider.shouldAutoClose()) {
       closeables.add(
           new AutoCloseable() {
@@ -405,6 +402,7 @@ public static final class Builder {
         InstantiatingExecutorProvider.newBuilder()
             .setExecutorThreadCount(THREADS_PER_CHANNEL)
             .build();
+    private static final AtomicInteger SYSTEM_EXECUTOR_COUNTER = new AtomicInteger();
 
     private String subscriptionName;
     private MessageReceiver receiver;
@@ -543,6 +541,28 @@ Builder setClock(ApiClock clock) {
     }
 
     public Subscriber build() {
+      if (systemExecutorProvider == null) {
+        ThreadFactory threadFactory =
+            new ThreadFactoryBuilder()
+                .setDaemon(true)
+                .setNameFormat("Subscriber-SE-" + SYSTEM_EXECUTOR_COUNTER.incrementAndGet() + "-%d")
+                .build();
+        int threadCount = Math.max(6, 2 * parallelPullCount);
+        final ScheduledExecutorService executor =
+            Executors.newScheduledThreadPool(threadCount, threadFactory);
+        systemExecutorProvider =
+            new ExecutorProvider() {
+              @Override
+              public boolean shouldAutoClose() {
+                return true;
+              }
+
+              @Override
+              public ScheduledExecutorService getExecutor() {
+                return executor;
+              }
+            };
+      }
       return new Subscriber(this);
     }
   }
