Skip to content

Commit 04f354a

Browse files
mderkamderka
committed
Added RPC layer of tests for local helpers. Closes #665.
Debugged parsing for options. Fixed context for the server URLs and regular expression parsing. Fixed paging. Improved error detection for missing zones vs. non-existent changes.
1 parent a1ec7f4 commit 04f354a

4 files changed

Lines changed: 1097 additions & 240 deletions

File tree

‎gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,9 @@ public Change getChangeRequest(String zoneName, String changeRequestId, Map<Opti
162162
} catch (IOException ex) {
163163
DnsException serviceException = translate(ex);
164164
if (serviceException.code() == HTTP_NOT_FOUND) {
165-
if (serviceException.location().equals("entity.parameters.changeId")) {
165+
if ((serviceException.location() != null
166+
&& serviceException.location().equals("entity.parameters.changeId"))
167+
|| serviceException.getMessage().contains("parameters.changeId")) {
166168
// the change id was not found, but the zone exists
167169
return null;
168170
}

0 commit comments

Comments
 (0)