Add nullable annotations, enable test (#2220)

michaelbausor · web-flow · commit 046777d5a3d1 · 2017-07-10T08:52:38.000-07:00
diff --git a/google-cloud-contrib/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java b/google-cloud-contrib/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java
@@ -133,7 +133,7 @@ protected Path computeNext() {
    * Sets options that are only used by the constructor.
    */
   @VisibleForTesting
-  public static void setStorageOptions(StorageOptions newStorageOptions) {
+  public static void setStorageOptions(@Nullable StorageOptions newStorageOptions) {
     futureStorageOptions = newStorageOptions;
   }
 
@@ -157,7 +157,7 @@ public static void setStorageOptions(StorageOptions newStorageOptions) {
    *
    * @param newDefault new default CloudStorageConfiguration
    */
-  public static void setDefaultCloudStorageConfiguration(CloudStorageConfiguration newDefault) {
+  public static void setDefaultCloudStorageConfiguration(@Nullable CloudStorageConfiguration newDefault) {
     CloudStorageFileSystem.setDefaultCloudStorageConfiguration(newDefault);
   }
 
diff --git a/google-cloud-contrib/google-cloud-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java b/google-cloud-contrib/google-cloud-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java
@@ -633,9 +633,7 @@ public void testNullness() throws Exception {
       tester.setDefault(Path.class, fs.getPath("and/one"));
       tester.setDefault(OpenOption.class, CREATE);
       tester.setDefault(CopyOption.class, COPY_ATTRIBUTES);
-      // can't do that, setStorageOptions accepts a null argument.
-      // TODO(jart): Figure out how to re-enable this.
-      // tester.testAllPublicStaticMethods(CloudStorageFileSystemProvider.class);
+      tester.testAllPublicStaticMethods(CloudStorageFileSystemProvider.class);
       tester.testAllPublicInstanceMethods(new CloudStorageFileSystemProvider());
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ protected Path computeNext() {`
`133`	`133`	`* Sets options that are only used by the constructor.`
`134`	`134`	`*/`
`135`	`135`	`@VisibleForTesting`
`136`		`- public static void setStorageOptions(StorageOptions newStorageOptions) {`
	`136`	`+ public static void setStorageOptions(@Nullable StorageOptions newStorageOptions) {`
`137`	`137`	`futureStorageOptions = newStorageOptions;`
`138`	`138`	`}`
`139`	`139`
`@@ -157,7 +157,7 @@ public static void setStorageOptions(StorageOptions newStorageOptions) {`
`157`	`157`	`*`
`158`	`158`	`* @param newDefault new default CloudStorageConfiguration`
`159`	`159`	`*/`
`160`		`- public static void setDefaultCloudStorageConfiguration(CloudStorageConfiguration newDefault) {`
	`160`	`+ public static void setDefaultCloudStorageConfiguration(@Nullable CloudStorageConfiguration newDefault) {`
`161`	`161`	`CloudStorageFileSystem.setDefaultCloudStorageConfiguration(newDefault);`
`162`	`162`	`}`
`163`	`163`
Original file line number	Diff line number	Diff line change
`@@ -633,9 +633,7 @@ public void testNullness() throws Exception {`
`633`	`633`	`tester.setDefault(Path.class, fs.getPath("and/one"));`
`634`	`634`	`tester.setDefault(OpenOption.class, CREATE);`
`635`	`635`	`tester.setDefault(CopyOption.class, COPY_ATTRIBUTES);`
`636`		`- // can't do that, setStorageOptions accepts a null argument.`
`637`		`- // TODO(jart): Figure out how to re-enable this.`
`638`		`- // tester.testAllPublicStaticMethods(CloudStorageFileSystemProvider.class);`
	`636`	`+ tester.testAllPublicStaticMethods(CloudStorageFileSystemProvider.class);`
`639`	`637`	`tester.testAllPublicInstanceMethods(new CloudStorageFileSystemProvider());`
`640`	`638`	`}`
`641`	`639`	`}`