Skip to content

Commit 0317bc8

Browse files
committed
---
yaml --- r: 4467 b: refs/heads/logging-alpha c: a8bee9c h: refs/heads/master i: 4465: 1026747 4463: 0b81aa5
1 parent 02f149e commit 0317bc8

7 files changed

Lines changed: 121 additions & 178 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ refs/heads/compute-alpha: 969cba2627f1d53d352cc4a5ffe0879dacf65e6c
1212
refs/heads/dns-alpha: 2f90e7e338349287ace33375896907af0f032ca1
1313
refs/heads/dns-alpha-batch: 17442b07867021b85d0452f5f3eda29a3413288f
1414
refs/heads/gcs-nio: 283aeaf15efdcf3621eb6859f05e55ad7764375d
15-
refs/heads/logging-alpha: 465f5327d81035666a12c1ef37bab0a1bfd55300
15+
refs/heads/logging-alpha: a8bee9c1e07337d1e710d378d7a600215e26c1ba
1616
refs/tags/v0.1.0: a615317f7424ed58621b1f65d5c4d8cbbe8a6ed8
1717
refs/tags/v0.1.1: 7a7f6985fe465e9dd6a075af55493f42b4933be0
1818
refs/tags/v0.1.2: 3eb3fe866ba22487686048f45d927b8c8638ea3f

branches/logging-alpha/gcloud-java-dns/src/main/java/com/google/gcloud/dns/AbstractOption.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,21 @@
1919
import static com.google.common.base.Preconditions.checkNotNull;
2020

2121
import com.google.common.base.MoreObjects;
22-
import com.google.gcloud.spi.DnsServiceRpc;
22+
import com.google.gcloud.spi.DnsRpc;
2323

2424
import java.io.Serializable;
2525
import java.util.Objects;
2626

2727
/**
2828
* A base class for options.
2929
*/
30-
public abstract class AbstractOption implements Serializable {
30+
abstract class AbstractOption implements Serializable {
3131

32-
private static final long serialVersionUID = 201601261704L;
32+
private static final long serialVersionUID = -5912727967831484228L;
3333
private final Object value;
34-
private final DnsServiceRpc.Option rpcOption;
34+
private final DnsRpc.Option rpcOption;
3535

36-
AbstractOption(DnsServiceRpc.Option rpcOption, Object value) {
36+
AbstractOption(DnsRpc.Option rpcOption, Object value) {
3737
this.rpcOption = checkNotNull(rpcOption);
3838
this.value = value;
3939
}
@@ -42,7 +42,7 @@ Object value() {
4242
return value;
4343
}
4444

45-
DnsServiceRpc.Option rpcOption() {
45+
DnsRpc.Option rpcOption() {
4646
return rpcOption;
4747
}
4848

@@ -52,18 +52,19 @@ public boolean equals(Object obj) {
5252
return false;
5353
}
5454
AbstractOption other = (AbstractOption) obj;
55-
return Objects.equals(value, other.value);
55+
return Objects.equals(value, other.value) && Objects.equals(rpcOption, other.rpcOption);
5656
}
5757

5858
@Override
5959
public int hashCode() {
60-
return Objects.hash(value);
60+
return Objects.hash(value, rpcOption);
6161
}
6262

6363
@Override
6464
public String toString() {
6565
return MoreObjects.toStringHelper(this)
6666
.add("value", value)
67+
.add("rpcOption", rpcOption)
6768
.toString();
6869
}
6970
}

0 commit comments

Comments
 (0)