---

mziccard · mziccard · commit 00bdc1b85797 · 2015-09-24T11:00:36.000+02:00
yaml --- r: 877 b: refs/heads/master c: ccc0230 h: refs/heads/master i: 875: 011730a v: v3
diff --git a/[refs] b/[refs]
@@ -1,4 +1,4 @@
 ---
-refs/heads/master: a10b74b73c5f5d5a2ed337503ddd4351f95d2a64
+refs/heads/master: ccc023045b446ac8d5e4b6e921171e09e3eac37e
 refs/heads/travis: 0fa997e2fc9c6b61b2d91e6d163655aae67d44b6
 refs/heads/gh-pages: 5a10432ecc75f29812e33a8236c900379509fe99
diff --git a/trunk/gcloud-java-storage/src/main/java/com/google/gcloud/storage/Bucket.java b/trunk/gcloud-java-storage/src/main/java/com/google/gcloud/storage/Bucket.java
@@ -23,8 +23,8 @@
 import com.google.gcloud.storage.Storage.BlobTargetOption;
 import com.google.gcloud.storage.Storage.BucketSourceOption;
 import com.google.gcloud.storage.Storage.BucketTargetOption;
-import java.util.LinkedList;
 
+import java.util.LinkedList;
 import java.util.List;
 import java.util.Objects;
 
diff --git a/trunk/gcloud-java-storage/src/test/java/com/google/gcloud/storage/BucketTest.java b/trunk/gcloud-java-storage/src/test/java/com/google/gcloud/storage/BucketTest.java
@@ -40,19 +40,19 @@
 
 public class BucketTest {
 
+  private static final BucketInfo BUCKET_INFO = BucketInfo.of("b");
   private static final Iterable<BlobInfo> BLOB_INFO_RESULTS = ImmutableList.of(
       BlobInfo.of("b", "n1"),
       BlobInfo.of("b", "n2"),
       BlobInfo.of("b", "n3"));
 
   private Storage storage;
   private Bucket bucket;
-  private final BucketInfo bucketInfo = BucketInfo.of("b");
 
   @Before
   public void setUp() throws Exception {
     storage = createStrictMock(Storage.class);
-    bucket = new Bucket(storage, bucketInfo);
+    bucket = new Bucket(storage, BUCKET_INFO);
   }
 
   @After
@@ -62,27 +62,27 @@ public void tearDown() throws Exception {
 
   @Test
   public void testInfo() throws Exception {
-    assertEquals(bucketInfo, bucket.info());
+    assertEquals(BUCKET_INFO, bucket.info());
     replay(storage);
   }
 
   @Test
   public void testExists_True() throws Exception {
-    expect(storage.get(bucketInfo.name())).andReturn(bucketInfo);
+    expect(storage.get(BUCKET_INFO.name())).andReturn(BUCKET_INFO);
     replay(storage);
     assertTrue(bucket.exists());
   }
 
   @Test
   public void testExists_False() throws Exception {
-    expect(storage.get(bucketInfo.name())).andReturn(null);
+    expect(storage.get(BUCKET_INFO.name())).andReturn(null);
     replay(storage);
     assertFalse(bucket.exists());
   }
 
   @Test
   public void testUpdate() throws Exception {
-    BucketInfo updatedInfo = bucketInfo.toBuilder().notFoundPage("p").build();
+    BucketInfo updatedInfo = BUCKET_INFO.toBuilder().notFoundPage("p").build();
     expect(storage.update(updatedInfo)).andReturn(updatedInfo);
     replay(storage);
     bucket.update(updatedInfo);
@@ -92,15 +92,15 @@ public void testUpdate() throws Exception {
 
   @Test
   public void testDelete() throws Exception {
-    expect(storage.delete(bucketInfo.name())).andReturn(true);
+    expect(storage.delete(BUCKET_INFO.name())).andReturn(true);
     replay(storage);
     assertTrue(bucket.delete());
   }
 
   @Test
   public void testList() throws Exception {
     BaseListResult<BlobInfo> blobInfoResult = new BaseListResult<>(null, "c", BLOB_INFO_RESULTS);
-    expect(storage.list(bucketInfo.name())).andReturn(blobInfoResult);
+    expect(storage.list(BUCKET_INFO.name())).andReturn(blobInfoResult);
     replay(storage);
     ListResult<Blob> blobResult = bucket.list();
     Iterator<BlobInfo> blobInfoIterator = blobInfoResult.iterator();
@@ -116,7 +116,7 @@ public void testList() throws Exception {
   @Test
   public void testGet() throws Exception {
     BlobInfo info = BlobInfo.of("b", "n");
-    expect(storage.get(bucketInfo.name(), "n")).andReturn(info);
+    expect(storage.get(BUCKET_INFO.name(), "n")).andReturn(info);
     replay(storage);
     Blob blob = bucket.get("n");
     assertEquals(info, blob.info());
