feat(bigquery): add table resource tags support#9084
Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom Dec 14, 2023
Merged
feat(bigquery): add table resource tags support#9084gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
Conversation
4 tasks
PhongChuong
approved these changes
Dec 14, 2023
This was referenced Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for resource tags on BigQuery tables.
Due to the nature of the feature, testing necessitates special provisioning with resourcemanager to establish a parent with the proper keys and values defined, which can then be bound to the table.
While implementing, testing was done in a personal test project, with the following commands to establish the necessary tags/values:
This integration test was used to smoke test that the feature works:
I've removed the integration test for the time being after verification, given the complexity of the setup outside of the BQ service.