test(profiler): use go 1.18.4 in integration test#6348
Merged
amchiclet merged 5 commits intogoogleapis:mainfrom Jul 18, 2022
Merged
test(profiler): use go 1.18.4 in integration test#6348amchiclet merged 5 commits intogoogleapis:mainfrom
amchiclet merged 5 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: xs
product-auto-label
Bot
added
size: s
amchiclet
changed the title
codyoss
reviewed
Jul 18, 2022
| retry curl -sL -o "$GIMME" https://raw.githubusercontent.com/travis-ci/gimme/master/gimme | ||
| chmod +x "$GIMME" | ||
|
|
||
| export GIMME_GO_VERSION=1.18.4 |
Member
There was a problem hiding this comment.
Our CI environment already tests on the max supported version and earliest supported version. For instance latest is already using 1.18. Maybe instead of re-downloading the toolchain you just detect that you are running from the latest job. I get there is a kokoro envvar you can read for this information.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I think you had similar feedback like last time.
These tests are extra, on top of the general CI tests that are performed in google-cloud-go.
The Go version being used in kokoro is v1.12. We hope to have a more controlled and custom VM for our tests, but unfortunately for now we will still have to use what kokoro provides.
Member
There was a problem hiding this comment.
@amchiclet I would consider looking into trampoline. You can bootstrap your env with a container. That is how the common CI works.
Contributor
Author
There was a problem hiding this comment.
Would love to do things the recommended way. Thanks for the pointer and will look into trampoline when we get a chance.
wyk9787
reviewed
Jul 18, 2022
wyk9787
approved these changes
Jul 18, 2022
Contributor
Author
|
I went ahead an merged this change. If needed, further improvements can be in follow up PRs. |
aalexand
reviewed
Jul 18, 2022
| "$GIMME" | ||
| # If gimme was successful, an .env script that sets up proper environment | ||
| # variables will be created. | ||
| if [[ -f "${GIMME_ENV_PREFIX}/go${GIMME_GO_VERSION}.env" ]] |
Contributor
There was a problem hiding this comment.
The script uses "set -eo pipefail", so is this conditional really necessary? If the gimme command fails we wouldn't get here. And even if we do, why not just do source "${GIMME_ENV_PREFIX}/go${GIMME_GO_VERSION}.env" unconditionally and let the command fail if the file is not there, which should fail the script?
Or is this to enable retries? It is not obvious from the comments.
Contributor
Author
There was a problem hiding this comment.
I think this can be cleaned up as you suggested. Thanks for pointing this out.
noahdietz
added a commit
that referenced
this pull request
Jul 18, 2022
* feat(storage): add Custom Placement Config Dual Region Support (#6294) * feat(storage): support Custom Dual Regions with CustomPlacementConfig * fix typo * add comments * address pr comments * new sublink * feat(bigquery/storage/managedwriter/adapt): support packed field option (#6312) * feat(bigquery/storage/managedwriter/adapt): support packed field option This PR adds the "packed" field option for repeated numeric scalar types when converting from table schema to proto descriptor. For large repetitions, this can yield wire size encoding benefits. This option is only relevant for proto2 descriptors; proto3 packs by default. * chore: update go version to 1.17 (#6342) This does not affect the version of Go we support. More details here: googleapis/go-genproto#859 * chore(all): auto-regenerate gapics (#6337) This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#857 Changes: feat(bigquery/migration): Add Presto dialect to bigquerymigration v2 client library PiperOrigin-RevId: 460797158 Source-Link: googleapis/googleapis@46f2598 * fix(bigquery/storage/managedwriter): improve network reconnection (#6338) * fix(bigquery/storage/managedwriter): improve network reconnection Issuing a sufficiently large single append request is enough to trigger the server backend to close an existing grpc stream. This PR addresses the problem by allowing a failed request to signal that subsequent requests should request a new grpc stream connection. This PR also adds an integration test that induces the failure by issuing a large request, and ensures subsequent requests succeed. Towards: #6321 * fix(pubsub): make receipt modack call async (#6335) * fix(pubsub): make receipt modack call async * dont propagate modack errors * update comment on why errors are not checked * chore(all): auto-regenerate gapics (#6347) This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#861 Changes: feat(dataplex): Add IAM support for Explore content APIs feat: Add support for custom container for Task feat: Add support for cross project for Task feat: Add support for custom encryption key to be used for encrypt data on the PDs associated with the VMs in your Dataproc cluster for Task feat: Add support for Latest job in Task resource feat: User mode filter in Explore list sessions API feat: Support logging sampled file paths per partition to Cloud logging for Discovery event PiperOrigin-RevId: 461116673 Source-Link: googleapis/googleapis@9af1b9b * chore(main): release bigquery 1.36.0 (#6343) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(storage): remove adapters dependency (#6350) The go-type-adapters package is used only minimally in storage, and nowhere else in google-cloud-go. Seems easiest to just drop this dependency. * doc(pubsub): clarify behavior of ack deadlines (#6301) * doc(pubsub): clarify behavior of ack deadlines * add 99th percentile documentation * chore(ci): add sync branch workflow for storage-refactor (#6334) * chore(ci): add sync branch workflow for storage-refactor * add change notes * only on weekdays * change job names * add cloud-storage-dpe to reviewers Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> * test(profiler): use go 1.18.4 in integration test (#6348) * chore: fix renovate (#6353) It has not processed in 20 days. I think we need to be careful with the PRs and have renovate try to do all the rebasing needed or else it seems to get confused and not able to recover. Fixes: #6352 * chore(main): release pubsub 1.24.0 (#6300) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Alex Hong <[email protected]> * chore(ci): storage-refactor sync use Yoshi Code Bot (#6355) Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Co-authored-by: cojenco <[email protected]> Co-authored-by: shollyman <[email protected]> Co-authored-by: Cody Oss <[email protected]> Co-authored-by: Yoshi Automation Bot <[email protected]> Co-authored-by: Alex Hong <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chris Cotter <[email protected]> Co-authored-by: Noah Dietz <[email protected]> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Co-authored-by: Amarin (Um) Phaosawasdi <[email protected]>
noahdietz
pushed a commit
that referenced
this pull request
Jul 18, 2022
noahdietz
added a commit
that referenced
this pull request
Jul 19, 2022
This reverts commit 6bb4fb8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also switching to use gimme (which is well tested and more robust) for the Go installation.
And also printing the go version before running the test, which is useful for debugging when something goes wrong.