testing(bigquery/storage/managewriter): confirm packed behaviors with normalization#6327
Merged
shollyman merged 3 commits intogoogleapis:mainfrom Jul 12, 2022
Merged
Conversation
normalization It turns out that packed repeated values are backwards compatible, so reading values doesn't require parity with the packed option in the writer. This PR adds tests for normalizing a proto3 descriptor of the various repeated scalar types, and adds a validation test to ensure packing behavior is as expected.
product-auto-label
Bot
added
size: m
yirutang
approved these changes
Jul 12, 2022
shollyman
added
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that packed repeated values are backwards compatible, so
reading values doesn't require parity with the packed option in the
writer.
This PR adds tests for normalizing a proto3 descriptor of the various
repeated scalar types, and adds a validation test to ensure packing
behavior is as expected.
Fixes: #6324