chore(storage): implement OpenReader, refactor gRPC read #6053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Contributor
Author
cojenco
reviewed
May 25, 2022
cojenco
reviewed
May 25, 2022
tritone
reviewed
May 27, 2022
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Couple minor naming things but overall looks great, very clean refactor!
tritone
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
storageClient.OpenReaderinterface for both HTTP and gRPC using the existing implementations inreader.go. This actually refactors the existing gRPC Reader implementation into the gRPC implementation of the interface. Testing locally showed that the integration tests still pass.