Skip to content

fix(storage): retry LockRetentionPolicy - #4439

Merged
tritone merged 1 commit into
googleapis:masterfrom
tritone:retention-retry
Jul 14, 2021
Merged

tritone merged 1 commit into
googleapis:masterfrom
tritone:retention-retry

Conversation

@tritone

@tritone tritone commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

This call is fully idempotent and retryable according to
go/gcs-api-retry-guidance.

Fixes #4437

This call is fully idempotent and retryable according to
go/gcs-api-retry-guidance.

Fixes googleapis#4437
@tritone
tritone requested review from a team July 14, 2021 21:42
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
@tritone
tritone requested a review from unforced July 14, 2021 21:42

@codyoss codyoss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone
tritone merged commit 09879ea into googleapis:master Jul 14, 2021
@tritone
tritone deleted the retention-retry branch July 14, 2021 22:58
gcf-merge-on-green Bot pushed a commit that referenced this pull request Aug 31, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.16.1](https://www.github.com/googleapis/google-cloud-go/compare/storage/v1.16.0...storage/v1.16.1) (2021-08-30)


### Bug Fixes

* **storage/internal:** Update encryption_key fields to "bytes" type. fix: Improve date/times and field name clarity in lifecycle conditions. ([a52baa4](https://www.github.com/googleapis/google-cloud-go/commit/a52baa456ed8513ec492c4b573c191eb61468758))
* **storage:** accept emulator env var without scheme ([#4616](https://www.github.com/googleapis/google-cloud-go/issues/4616)) ([5f8cbb9](https://www.github.com/googleapis/google-cloud-go/commit/5f8cbb98070109e2a34409ac775ed63b94d37efd))
* **storage:** preserve supplied endpoint's scheme ([#4609](https://www.github.com/googleapis/google-cloud-go/issues/4609)) ([ee2756f](https://www.github.com/googleapis/google-cloud-go/commit/ee2756fb0a335d591464a770c9fa4f8fe0ba2e01))
* **storage:** remove unnecessary variable ([#4608](https://www.github.com/googleapis/google-cloud-go/issues/4608)) ([27fc784](https://www.github.com/googleapis/google-cloud-go/commit/27fc78456fb251652bdf5cdb493734a7e1e643e1))
* **storage:** retry LockRetentionPolicy ([#4439](https://www.github.com/googleapis/google-cloud-go/issues/4439)) ([09879ea](https://www.github.com/googleapis/google-cloud-go/commit/09879ea80cb67f9bfd8fc9384b0fda335567cba9)), refs [#4437](https://www.github.com/googleapis/google-cloud-go/issues/4437)
* **storage:** revise Reader to send XML preconditions ([#4479](https://www.github.com/googleapis/google-cloud-go/issues/4479)) ([e36b29a](https://www.github.com/googleapis/google-cloud-go/commit/e36b29a3d43bce5c1c044f7daf6e1db00b0a49e0)), refs [#4470](https://www.github.com/googleapis/google-cloud-go/issues/4470)

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage: TestIntegration_LockBucket failed

2 participants