test(bigquery): add integration test for Column ACLs#3895
Merged
shollyman merged 2 commits intogoogleapis:masterfrom Apr 7, 2021
Merged
test(bigquery): add integration test for Column ACLs#3895shollyman merged 2 commits intogoogleapis:masterfrom
shollyman merged 2 commits intogoogleapis:masterfrom
Conversation
Now that we have a v1 PTM client, we can test the policy tag integration with column ACLs. This also plumbed in a new client as part of the integration testing setup, much like we make a cloud storage client available.
product-auto-label
Bot
added
the
api: bigquery
google-cla
Bot
added
the
cla: yes
tswast
reviewed
Apr 6, 2021
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Looks good! I assume we aren't trying to test the actual Column ACLs query logic because that's not a client responsibility?
Contributor
Author
Yup. We're not the right place for this level of e2e enforcement validation. |
tswast
approved these changes
Apr 7, 2021
codyoss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a v1 PolicyTagManager client, we can test the policy tag integration
with column ACLs.
This also plumbed in a new PTM client as part of the integration testing
setup, much like we make a cloud storage client available.